Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frequent timeouts for CI / base (3.9) #1077

Closed
dweindl opened this issue Jun 6, 2023 · 7 comments
Closed

Frequent timeouts for CI / base (3.9) #1077

dweindl opened this issue Jun 6, 2023 · 7 comments
Assignees
@PaulJonasJost
Labels
CI

Comments

@dweindl
Copy link
Member

dweindl commented Jun 6, 2023 •
edited
Loading

e.g. https://github.com/ICB-DCM/pyPESTO/actions/runs/5187107504/jobs/9349064642?pr=1073
https://github.com/ICB-DCM/pyPESTO/actions/runs/5187543834/jobs/9350030555?pr=1068

Increase timeouts or speed up tests?

edit: also happening for CI / optimize (3.9), but less frequently.
@dweindl dweindl changed the title Frequent timeouts for CI / base (3.9) Frequent timeouts for CI / base (3.9) Jun 6, 2023
@PaulJonasJost PaulJonasJost self-assigned this Jun 19, 2023
@PaulJonasJost PaulJonasJost mentioned this issue Jun 22, 2023
Merged
@dweindl
Copy link
Member Author

dweindl commented Aug 24, 2023

Still happening. Now also for julia tests (e.g. https://github.com/ICB-DCM/pyPESTO/actions/runs/5959628067/job/16166590355)

@dweindl
Copy link
Member Author

dweindl commented Aug 31, 2023

Also for the mac tests: e.g. https://github.com/ICB-DCM/pyPESTO/actions/runs/6034032186/job/16371678336

@PaulJonasJost
Copy link
Collaborator

base should be faster in newer version now.

@dweindl
Copy link
Member Author

dweindl commented Oct 30, 2023 •
edited
Loading

base should be faster in newer version now.

Times out less frequently, but still does occasionally:
https://github.com/ICB-DCM/pyPESTO/actions/runs/6697723646/job/18198209071
https://github.com/ICB-DCM/pyPESTO/actions/runs/6698596660/job/18201014726
https://github.com/ICB-DCM/pyPESTO/actions/runs/6698592427/job/18200999956
https://github.com/ICB-DCM/pyPESTO/actions/runs/6706797750/job/18223976168

@dweindl
Copy link
Member Author

dweindl commented Oct 31, 2023

While I think it's good to keep the test suite as compact as possible, I would also suggest to just extend the time limits. With re-running all the timed-out tests the current limits waste more time than they save.

@PaulJonasJost
Copy link
Collaborator

Yes, think that is a good idea. What I also noticed is that the tests seem to run out if too many actions run at the same time. Partially this might be due to two reasons:

  • Merge develop into most/all open PRs
  • Multiple commits into a single PR as this triggers an action but does not cancel the previous one

@dweindl
Copy link
Member Author

dweindl commented Nov 17, 2023

Also for notebook tests, e.g. https://github.com/ICB-DCM/pyPESTO/actions/runs/6903646092/job/18782766099

@dweindl dweindl mentioned this issue Nov 20, 2023
Merged
dweindl added a commit to dweindl/pyPESTO that referenced this issue Nov 21, 2023
@dweindl
Speed up test.sample.test_sample.test_pipeline
f1a61b3 
There is really no need to run `pypesto.visualize.sampling.sampling_1d_marginals` over 20 times.

It seems this was the cause of ICB-DCM#1077. In some cases, plotting takes over 10min (cancelled at some point, not sure it would ever complete).
Maybe somebody using this function would like to investigate that further...
@dweindl dweindl mentioned this issue Nov 21, 2023
Merged
dweindl added a commit that referenced this issue Nov 21, 2023
@dweindl
Speed up test.sample.test_sample.test_pipeline (#1208)
2d95ca4 
There is really no need to run `pypesto.visualize.sampling.sampling_1d_marginals` over 20 times.

It seems this was the cause of #1077. In some cases, plotting takes over 10min (cancelled at some point, not sure it would ever complete).
Maybe somebody using this function would like to investigate that further...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulJonasJost PaulJonasJost

Labels
CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dweindl @PaulJonasJost