Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to develop AMICI and fix RTD SSL error. #30

Merged
merged 18 commits into from
May 9, 2023
Merged

Switch to develop AMICI and fix RTD SSL error. #30

merged 18 commits into from
May 9, 2023

Conversation

stephanmg
Copy link
Contributor

@stephanmg stephanmg commented May 9, 2023 •
edited
Loading

Should fix GHA workflow.

@stephanmg stephanmg changed the title Remove custom AMICI. Remove custom AMICI and fix RTD. May 9, 2023
@stephanmg stephanmg requested a review from dilpath May 9, 2023 14:15
@stephanmg
Copy link
Contributor Author

stephanmg commented May 9, 2023 •
edited
Loading

Please see problematic Sphinx extension in doc/conf.py which I did temporarily disable. Not sure how to fix the error emanating from the MagicMock object.

@stephanmg stephanmg changed the title Remove custom AMICI and fix RTD. Switch to develop AMICI and fix RTD SSL error. May 9, 2023
dilpath
dilpath approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the various fixes!

doc/conf.py Outdated Show resolved Hide resolved
@dilpath dilpath merged commit 796c936 into ICB-DCM:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilpath dilpath dilpath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanmg @dilpath