Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): fix circular structure caused by aria-owns #2164

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Jan 24, 2025

  • Other (Provide information): engine bug related to aria-own

This PR is related to the following issue(s):

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other - using Chrome and Firefox artifacts.

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@shunguoy shunguoy requested a review from tombrunet January 24, 2025 14:37
@shunguoy shunguoy marked this pull request as ready for review January 24, 2025 14:37
@philljenkins philljenkins self-requested a review January 30, 2025 18:49
@philljenkins philljenkins self-assigned this Jan 30, 2025
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested PR using

using Chrome and Firefox artifacts.

  1. Correctly does not trigger na getNodeHierarchy error in Console
  2. Correctly reports the issue on aria_own_circular.html
  3. Since no changes to rules, mapping, or help there was no additional verification of PR

@tombrunet tombrunet merged commit dea41a2 into master Feb 4, 2025
17 checks passed
evannaderi pushed a commit to evannaderi/ace-engine that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stackoverflow in getNodeHierarchy
3 participants