fixrule(meta_refresh_delay | meta_redirect_optional) Fix the rules to algin with ACT

.github/ISSUE_TEMPLATE/accessibility_issue.yaml

@@ -51,7 +51,7 @@ body:
   - type: input
     id: tool
     attributes:
-      label: Automated testing tool and ruleset.
+      label: Automated testing tool and ruleset
       description: 'Which tool and ruleset uncovered the issue?'
       placeholder: e.g. IBM Equal Access Accessibility Checker - Latest Deployment
   - type: input
@@ -77,16 +77,4 @@ body:
         'How do we reproduce the accessibility violation you described?'
     validations:
       required: true
-  - type: markdown
-    attributes:
-      value: |
-        ### Definition of Done
-        (DO NOT EDIT THIS SECTION. This section is for IBM internal use only.)
-        - [ ] Design artifacts reviewed
-        - [ ] Work item implemented
-        - [ ] Automated test case created (when applicable)
-        - [ ] Unit test completed
-        - [ ] Run Checker (when applicable)
-        - [ ] Manual and Screen Reader Testing (when applicable)
-        - [ ] Video recording of user experience walkthrough (if impact to UX)
-        - [ ] PR created
+

.github/ISSUE_TEMPLATE/bug_report.yaml

@@ -63,18 +63,4 @@ body:
         'How do we reproduce the issue you described using the?'
     validations:
       required: true
-  - type: markdown
-    attributes:
-      value: |
-        ### Definition of Done
-        (DO NOT EDIT THIS SECTION. This section is for IBM internal use only.)
-        - [ ] Design artifacts reviewed
-        - [ ] Work item implemented
-        - [ ] Automated test case created (when applicable)
-        - [ ] Unit test completed
-        - [ ] Run Checker (when applicable)
-        - [ ] Manual and Screen Reader Testing (when applicable)
-        - [ ] Video recording of user experience walkthrough (if impact to UX)
-        - [ ] PR created      
-
 

.github/pull_request_template.md

@@ -23,20 +23,6 @@
 - [ ] This PR has been reviewed and is ready for test  
 - [ ] I understand that the title of this PR will be used for the next release notes.
 
-
-### Assets to aide review attached
-<!-- DO NOT EDIT THIS SECTION. This section is for IBM internal review only. Specify the additional artifacts that should be reviewed alongside this PR. -->
-- [ ] Links to design artifacts 
-- [ ] Links to video walkthrough of user experience 
-- [ ] Other
-
-### Definition of Done
-<!-- DO NOT EDIT THIS SECTION. This section is for IBM internal review only. Verify that the following requirements are met prior to marking this PR (issue) as Done. -->
-- [ ] Peer review complete
-- [ ] Secondary review complete
-- [ ] Staging deployment verified
-
-
 <!--
 -- TITLE INSTRUCTIONS START: DO NOT EDIT THIS SECTION --
 The title of this PR will be used for release notes, please provide a relevant title. 
@@ -49,4 +35,4 @@ The following templates should be used for the PR titles:
 
 Please review more info: https://github.com/IBMa/equal-access/wiki/Release-notes 
 -- TITLE INSTRUCTIONS END --
--->
+-->

.github/workflows/master.yml

@@ -44,7 +44,7 @@ jobs:
     - run: npm run package:browser
       working-directory: accessibility-checker-extension
     - name: Upload packed extension
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v1
       with:
         name: accessibility-checker-extension for Chrome
         path: accessibility-checker-extension/package/accessibility-checker-extension.zip
@@ -53,7 +53,7 @@ jobs:
     - run: npm run package:browser
       working-directory: accessibility-checker-extension
     - name: Upload packed extension
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v1
       with:
         name: accessibility-checker-extension for Firefox
         path: accessibility-checker-extension/package/accessibility-checker-extension.zip
@@ -92,7 +92,7 @@ jobs:
     - run: npm test
       working-directory: accessibility-checker/test-act-w3
     - name: Upload packed extension
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v1
       with:
         name: ACT Text Results
         path: accessibility-checker/test-act-w3/act-report-v2.txt

.github/workflows/publish.yml

@@ -173,7 +173,7 @@ jobs:
     - run: npm run package:browser
       working-directory: accessibility-checker-extension
     - name: Upload packed extension
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v1
       with:
         name: accessibility-checker-extension for Chrome
         path: accessibility-checker-extension/package/accessibility-checker-extension.zip
@@ -195,7 +195,7 @@ jobs:
     - run: npm run package:browser
       working-directory: accessibility-checker-extension
     - name: Upload packed extension
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v1
       with:
         name: accessibility-checker-extension for Firefox
         path: accessibility-checker-extension/package/accessibility-checker-extension.zip
@@ -222,46 +222,4 @@ jobs:
         BLUEMIX_USERID: apikey
         BLUEMIX_PASS: ${{ secrets.BLUEMIX_PASS }}
         CLOUD_PWD: ${{ secrets.CLOUD_PWD }}
-        TRAVIS_BRANCH: prod
-
-  java-accessibility-checker-deploy:
-    runs-on: ubuntu-22.04
-    permissions:
-      packages: write
-    strategy:
-      matrix:
-        node-version: [18.x]
-
-    steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-java@v4
-      with:
-        distribution: 'semeru' # See 'Supported distributions' for available options
-        java-version: '17'
-        server-id: central
-        server-username: ${{ secrets.MVN_GITHUB_USER }}
-        server-password: ${{ secrets.MVN_GITHUB_TOKEN }}
-    - uses: s4u/[email protected]
-      with:
-        servers: |
-          [{
-            "id": "central",
-            "username": "${{ secrets.MVN_GITHUB_USER }}",
-            "password": "${{ secrets.MVN_GITHUB_TOKEN }}"
-          }]
-    - name: Configure GPG Key
-      run: echo "$GPG_SIGNING_KEY" >private.key
-      env:
-        GPG_SIGNING_KEY: ${{ secrets.GPG_SIGNING_KEY }}
-    - name: Import GPG Key
-      run: gpg --pinentry-mode=loopback --passphrase "$GPG_SIGNING_KEY_PASS" --import private.key
-      env:
-        GPG_SIGNING_KEY_PASS: ${{ secrets.GPG_SIGNING_KEY_PASS }}
-    - name: Set version
-      run: sed -i'.old' -e 's/<version>3\.0\.0<\/version>/<version>'"${GITHUB_REF:10}"'<\/version>/g' ./pom.xml
-      working-directory: java-accessibility-checker
-    - name: Publish package
-      run: mvn --batch-mode deploy -DskipTests -Dgpg.passphrase=$GPG_SIGNING_KEY_PASS
-      working-directory: java-accessibility-checker
-      env:
-        GPG_SIGNING_KEY_PASS: ${{ secrets.GPG_SIGNING_KEY_PASS }}
+        TRAVIS_BRANCH: prod

.github/workflows/test.yml

@@ -42,15 +42,10 @@ jobs:
     - run: npx mocha ./test/mocha/help/help.test.js
       working-directory: accessibility-checker-engine
     - name: Upload rule listing
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v1
       with:
         name: Rule listing
         path: accessibility-checker-engine/dist/help/rules.html
-    - name: Upload rule mapping spreadsheet
-      uses: actions/upload-artifact@v4
-      with:
-        name: Rule mapping spreadsheet
-        path: accessibility-checker-engine/dist/help/rules.csv
 
 
   act-results:
@@ -89,7 +84,7 @@ jobs:
     - run: npm test
       working-directory: accessibility-checker/test-act-w3
     - name: Upload packed extension
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v1
       with:
         name: ACT Text Results
         path: accessibility-checker/test-act-w3/act-report-v2.txt
@@ -366,77 +361,6 @@ jobs:
     - run: npm run wdio
       working-directory: accessibility-checker/test/webdriverio
 
-###############################################################################
-# Java test
-####
-  java-accessibility-checker-selenium-test:
-    runs-on: ubuntu-22.04
-
-    strategy:
-      matrix:
-        node-version: [18.x]
-
-    steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-java@v4
-      with:
-        distribution: 'semeru' # See 'Supported distributions' for available options
-        java-version: '17'
-    - name: Latest Chrome
-      uses: browser-actions/setup-chrome@v1
-      with:
-        chrome-version: latest
-        install-chromedriver: true
-      id: setup-chrome
-    - run: npm install
-      working-directory: rule-server
-    - run: npm run build
-      working-directory: rule-server
-    - run: node main.js &
-      working-directory: rule-server/dist
-    - run: sleep 10
-      working-directory: rule-server/dist
-    - name: Test package
-      run: mvn --batch-mode test -Dtest="AccessibilityCheckerSeleniumTest"
-      working-directory: java-accessibility-checker
-      env: 
-        chromedriverpath: ${{ steps.setup-chrome.outputs.chromedriver-path }}
-        chromebinpath: ${{ steps.setup-chrome.outputs.chrome-path }}
-
-  java-accessibility-checker-playwright-test:
-    runs-on: ubuntu-22.04
-
-    strategy:
-      matrix:
-        node-version: [18.x]
-
-    steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-java@v4
-      with:
-        distribution: 'semeru' # See 'Supported distributions' for available options
-        java-version: '17'
-    - name: Latest Chrome
-      uses: browser-actions/setup-chrome@v1
-      with:
-        chrome-version: latest
-        install-chromedriver: true
-      id: setup-chrome
-    - run: npm install
-      working-directory: rule-server
-    - run: npm run build
-      working-directory: rule-server
-    - run: node main.js &
-      working-directory: rule-server/dist
-    - run: sleep 10
-      working-directory: rule-server/dist
-    - name: Test package
-      run: mvn --batch-mode test -Dtest="AccessibilityCheckerPlaywrightTest"
-      working-directory: java-accessibility-checker
-      env: 
-        chromedriverpath: ${{ steps.setup-chrome.outputs.chromedriver-path }}
-        chromebinpath: ${{ steps.setup-chrome.outputs.chrome-path }}
-
 ###############################################################################
 # Karma Tests
 ####
@@ -567,7 +491,7 @@ jobs:
       run: npm test
       working-directory: accessibility-checker-extension/test
     - name: Upload packed extension
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v1
       with:
         name: accessibility-checker-extension for Chrome
         path: accessibility-checker-extension/package/accessibility-checker-extension.zip
@@ -576,7 +500,7 @@ jobs:
     - run: npm run package:browser
       working-directory: accessibility-checker-extension
     - name: Upload packed extension
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v1
       with:
         name: accessibility-checker-extension for Firefox
         path: accessibility-checker-extension/package/accessibility-checker-extension.zip

accessibility-checker-engine/help-v4/en-US/label_ref_valid.html

@@ -45,16 +45,16 @@ <h3 id="ruleMessage"></h3>
 
 ### Why is this important?
 
-A `<label>` element is attached to a specific element, such as `<input>` and `<select>`, through the `for` attribute. 
-When a `<label>` does not reference the corresponding unique `id` in a valid element, 
+A `<label>` element is attached to a specific `<input>` element through the `for` attribute. 
+When a `<label>` does not reference the corresponding unique `id` in a valid `<input>` element, 
 assistive technologies cannot associate the label with the element.
 
 <!-- This is where the code snippet is injected -->
 <div id="locSnippet"></div>
 
 ### What to do
 
-* Set the value of the `for` attribute to the `id` value of the valid element to be labeled. Make sure the `id` value is unique. 
+* Set the value of the `for` attribute to the `id` value of the valid `<input>` element to be labeled. Make sure the `id` value is unique. 
 
 For example:
 

accessibility-checker-engine/karma.conf.js

@@ -46,13 +46,17 @@
                 // { pattern: 'test/v2/checker/accessibility/rules/Rpt_Aria_RequiredParent_Native_Host_Sematics_ruleunit/ACT_ff89c9_pass4.html', watched: true },
                 //{ pattern: 'test/v2/checker/accessibility/rules/label_name_visible_ruleunit/label_offscreen.html', watched: true },
                 //{ pattern: 'test/v2/checker/accessibility/rules/aria_role_valid_ruleunit/td_attribute_invalid_copy.html', watched: true },
+<<<<<<< HEAD
                 //{ pattern: 'test/v2/checker/accessibility/rules/text_block_heading_ruleunit/Headings-noneUsedEmphasizedText.html', watched: true },
-                { pattern: 'test/v2/checker/accessibility/rules/aria_landmark_name_unique_ruleunit/*.html', watched: true },
+                //{ pattern: 'test/v2/checker/accessibility/rules/meta_redirect_optional_ruleunit/*.html', watched: true },
                 // { pattern: 'test/v2/checker/accessibility/rules/aria_parent_required_ruleunit/webComponentPass2.html', watched: true },
+=======
+                //{ pattern: 'test/v2/checker/accessibility/rules/label_name_visible_ruleunit/label_multiple_offscreen.html', watched: true },
+>>>>>>> parent of 01c107fb (chore(repo): Update main-4.x (#2118))
 
 
-                // { pattern: 'test/**/*_ruleunit/*.html', watched: true },
-                // { pattern: 'test/**/*_ruleunit/*.htm', watched: true },
+                { pattern: 'test/**/*_ruleunit/*.html', watched: true },
+                { pattern: 'test/**/*_ruleunit/*.htm', watched: true },
                 // all files ending in "_test"
                 // { pattern: 'test/*_test.js', watched: true },
                 { pattern: 'test/**/*_test.js', watched: true }

accessibility-checker-engine/karmaaction.conf.js

@@ -63,7 +63,7 @@ module.exports = (config) => {
         customLaunchers: {
             ChromeCustom: {
                 base: 'ChromeHeadless',
-                flags: ['--disable-gpu', '--disable-web-security', '--no-sandbox']
+                flags: ['--disable-web-security', '--no-sandbox']
             }
         },
         preprocessors: {