Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Reset filter link not working in new extension design #1877

Closed
tombrunet opened this issue Mar 20, 2024 · 2 comments · Fixed by #2136
Closed

[BUG]: Reset filter link not working in new extension design #1877

tombrunet opened this issue Mar 20, 2024 · 2 comments · Fixed by #2136
Assignees
@nam-singh
Labels
extension-checker Issues related to the browser extensions priority-2 (med) T61

Comments

@tombrunet
Copy link
Member

Project

extension-checker

Browser

Chrome

Operating system

MacOS

Description

When no issues are shown, there is a link to "select all issue types", but it is not working. Screenshot:

image

Steps to reproduce

Scan any page. Open the filter dropdown and uncheck everything. You'll see the "No issues ..." message. The "select all issue types" is not resetting the filters. We might want to change "select all issue types" to "reset the filters".
@tombrunet tombrunet added the extension-checker Issues related to the browser extensions label Mar 20, 2024
@philljenkins
Copy link
Contributor

philljenkins commented Mar 21, 2024 •
edited
Loading

clicking on the link incorrectly does nothing. The blue underlined text should

  1. either be a link to someplace, such as to the quick guide:
    e.g. Quick guide - Filter views chrome-extension://lkcagbfjnkomcinoddgooolagloogehp/quickGuideAC.html#filter
  2. or a button should be added (not a link) to do the function
  3. or both a button and link to Quick quide

@shunguoy shunguoy added the T61 label Mar 25, 2024
@MHoov MHoov assigned nam-singh and unassigned drjoho Dec 17, 2024
@nam-singh nam-singh mentioned this issue Dec 28, 2024
Merged
11 tasks
@nam-singh
Copy link
Contributor

Fixes in PR:#2136
Video Walkthrough of Fix:https://ibm-my.sharepoint.com/:v:/p/nam_singh/EfgdJEZffzZNgqKG_jUbFdoBdNH6mLgQ-8sJ5qVUwQv-Vw?nav=eyJyZWZlcnJhbEluZm8iOnsicmVmZXJyYWxBcHAiOiJPbmVEcml2ZUZvckJ1c2luZXNzIiwicmVmZXJyYWxBcHBQbGF0Zm9ybSI6IldlYiIsInJlZmVycmFsTW9kZSI6InZpZXciLCJyZWZlcnJhbFZpZXciOiJNeUZpbGVzTGlua0NvcHkifX0&e=kaEWcy

tombrunet added a commit that referenced this issue Jan 2, 2025
@nam-singh @tombrunet
fix(extension):Fix reset filter link #1877 (#2136)
6946ed2 
* reset filter fix

* css fix

---------

Co-authored-by: Tom Brunet <[email protected]>
tombrunet added a commit that referenced this issue Jan 14, 2025
@tombrunet @dependabot @nam-singh
chore(repo): Update main-4.x for Jan release (#2148)
981a467 
* Bump path-to-regexp and express in /rule-server (#2128)

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.12 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.10 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12)

Updates `express` from 4.21.0 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.21.0...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>

* fix dark mode react portal pop-up (#2138)

* fix(extension):Fix reset filter link #1877 (#2136)

* reset filter fix

* css fix

---------

Co-authored-by: Tom Brunet <[email protected]>

* fix(extension): Don't show full data:text/html content on generated HTML report page  (#2140)

* truncating url

* remove unused import

* Adjust tooltip location

---------

Co-authored-by: Tom Brunet <[email protected]>

* chore(extension): carbon package update and use new carbon combobutton #1842 (#2137)

* carbon package update and use new carbon combobutton

* alignment fix

---------

Co-authored-by: Tom Brunet <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Namrata Singh <[email protected]>
tombrunet added a commit that referenced this issue Feb 4, 2025
@shunguoy @dependabot
@tombrunet @nam-singh
fixrule(meta_refresh_delay | meta_redirect_optional) Fix the rules to…
a5559ab 
… align with ACT V4 (#2168)

* Bump path-to-regexp and express in /rule-server (#2128)

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.12 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.10 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12)

Updates `express` from 4.21.0 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.21.0...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>

* fix dark mode react portal pop-up (#2138)

* fix(extension):Fix reset filter link #1877 (#2136)

* reset filter fix

* css fix

---------

Co-authored-by: Tom Brunet <[email protected]>

* fix(extension): Don't show full data:text/html content on generated HTML report page  (#2140)

* truncating url

* remove unused import

* Adjust tooltip location

---------

Co-authored-by: Tom Brunet <[email protected]>

* chore(extension): carbon package update and use new carbon combobutton #1842 (#2137)

* carbon package update and use new carbon combobutton

* alignment fix

---------

Co-authored-by: Tom Brunet <[email protected]>

* Update the rules and test cases

* update the baselines

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>
Co-authored-by: Namrata Singh <[email protected]>
tombrunet added a commit that referenced this issue Feb 4, 2025
@shunguoy @dependabot
@tombrunet @nam-singh
fix(engine): fix circular structure caused by aria-owns V4 (#2166)
968333c 
* Bump path-to-regexp and express in /rule-server (#2128)

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.12 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.10 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12)

Updates `express` from 4.21.0 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.21.0...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>

* fix dark mode react portal pop-up (#2138)

* fix(extension):Fix reset filter link #1877 (#2136)

* reset filter fix

* css fix

---------

Co-authored-by: Tom Brunet <[email protected]>

* fix(extension): Don't show full data:text/html content on generated HTML report page  (#2140)

* truncating url

* remove unused import

* Adjust tooltip location

---------

Co-authored-by: Tom Brunet <[email protected]>

* chore(extension): carbon package update and use new carbon combobutton #1842 (#2137)

* carbon package update and use new carbon combobutton

* alignment fix

---------

Co-authored-by: Tom Brunet <[email protected]>

* fix circular structure caused by aria-owns

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>
Co-authored-by: Namrata Singh <[email protected]>
tombrunet added a commit that referenced this issue Feb 4, 2025
@shunguoy @dependabot
@tombrunet @nam-singh
fix(engine): Fix issues related to accessible name concatenation and …
a08baf4 
…deprecate aria_search_label_unique rule V4 (#2178)

* Bump path-to-regexp and express in /rule-server (#2128)

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.12 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.10 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12)

Updates `express` from 4.21.0 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.21.0...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>

* fix dark mode react portal pop-up (#2138)

* fix(extension):Fix reset filter link #1877 (#2136)

* reset filter fix

* css fix

---------

Co-authored-by: Tom Brunet <[email protected]>

* fix(extension): Don't show full data:text/html content on generated HTML report page  (#2140)

* truncating url

* remove unused import

* Adjust tooltip location

---------

Co-authored-by: Tom Brunet <[email protected]>

* chore(extension): carbon package update and use new carbon combobutton #1842 (#2137)

* carbon package update and use new carbon combobutton

* alignment fix

---------

Co-authored-by: Tom Brunet <[email protected]>

* update the rule logic and add new test cases #2122

* update act mapping #dev-2122-new

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>
Co-authored-by: Namrata Singh <[email protected]>
tombrunet added a commit that referenced this issue Feb 4, 2025
@tombrunet @dependabot @nam-singh
chore(repo): Add note of unapproved in ACT txt debug result (for 4.x …
4707675 
…branch) (#2181)

* Bump path-to-regexp and express in /rule-server (#2128)

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.12 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.10 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12)

Updates `express` from 4.21.0 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.21.0...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>

* fix dark mode react portal pop-up (#2138)

* fix(extension):Fix reset filter link #1877 (#2136)

* reset filter fix

* css fix

---------

Co-authored-by: Tom Brunet <[email protected]>

* fix(extension): Don't show full data:text/html content on generated HTML report page  (#2140)

* truncating url

* remove unused import

* Adjust tooltip location

---------

Co-authored-by: Tom Brunet <[email protected]>

* chore(extension): carbon package update and use new carbon combobutton #1842 (#2137)

* carbon package update and use new carbon combobutton

* alignment fix

---------

Co-authored-by: Tom Brunet <[email protected]>

* Add note of unapproved in ACT txt result

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Namrata Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nam-singh nam-singh

Labels
extension-checker Issues related to the browser extensions priority-2 (med) T61
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(extension):Fix reset filter link #1877 IBMa/equal-access
5 participants
@philljenkins @shunguoy @tombrunet @drjoho @nam-singh