Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Rpt_Aria_MissingFocusableChild - shouldn't trigger for menu popup #1402

Closed
tombrunet opened this issue Apr 17, 2023 · 5 comments
Closed

[BUG]: Rpt_Aria_MissingFocusableChild - shouldn't trigger for menu popup #1402

tombrunet opened this issue Apr 17, 2023 · 5 comments
Assignees
@shunguoy @ErickRenteria
Labels
Bug Something isn't working priority-1 (high) Ready for QA user-reported Issues identified outside of the core team

Comments

@tombrunet
Copy link
Member

Project

a11y checker engine

Browser

Chrome

Operating system

MacOS

Description

See Carbon overflow menu example: https://react.carbondesignsystem.com/iframe.html?args=&id=components-overflowmenu--default&viewMode=story

An overflow menu disappears when it loses focus, so there is no requirement to be able to tab back to it. We currently ignore comboboxes that control popups. We should ignore popups that are controlled by buttons with aria-controls also. Not sure if it should also indicate popup or aria-exanded?

Steps to reproduce

See description. The Carbon overflow does not currently have the aria-controls, but should be enough to build a quick testcase to confirm a fix.
@francinelucca
Copy link

Carbon issue: carbon-design-system/carbon#12728

@francinelucca francinelucca mentioned this issue Apr 17, 2023
Open
2 tasks
@MHoov MHoov added Bug Something isn't working user-reported Issues identified outside of the core team labels Apr 24, 2023
@shunguoy
Copy link
Contributor

Screenshot 2023-04-24 at 2 06 19 PM

@shunguoy shunguoy self-assigned this Apr 24, 2023
@francinelucca francinelucca mentioned this issue Jun 1, 2023
Merged
22 tasks
@shunguoy
Copy link
Contributor

shunguoy commented Jun 7, 2023

raised priority to 1 to help to close the Carbon issue.

shunguoy added a commit that referenced this issue Jun 8, 2023
@shunguoy
update roles and add test cases #1402
8d0c50d
shunguoy added a commit that referenced this issue Jun 9, 2023
@shunguoy
update the rule and test results #1402
4492bfd
@shunguoy shunguoy mentioned this issue Jun 12, 2023
Merged
1 task
@ErickRenteria
Copy link
Contributor

merged

@francinelucca
Copy link

Thanks! is there a release schedule we can check to know when this will be available in the tool?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shunguoy shunguoy

@ErickRenteria ErickRenteria

Labels
Bug Something isn't working priority-1 (high) Ready for QA user-reported Issues identified outside of the core team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@shunguoy @tombrunet @francinelucca @MHoov @ErickRenteria