Skip to content

Commit

Permalink
Merge branch 'master' into dev-1336
Browse files Browse the repository at this point in the history
  • Loading branch information
tombrunet authored May 10, 2023
2 parents 48759a9 + 13b5db3 commit cef6c8b
Show file tree
Hide file tree
Showing 1,484 changed files with 14,455 additions and 10,452 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,8 @@ jobs:
strategy:
matrix:
node-version: [16.x]
test-file: [karma.conf1.js, karma.conf1b.js, karma.conf2.js, karma.conf2b.js, karma.conf3.js]
# test-file: [karma.conf1.js, karma.conf1b.js, karma.conf2.js, karma.conf2b.js, karma.conf3.js] // conf1 and conf2 fail a lot
test-file: [karma.conf1b.js, karma.conf2b.js, karma.conf3.js]

steps:
- uses: actions/checkout@v3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,30 +44,20 @@ <h3 id="ruleMessage"></h3>

### Why is this important?

Functionally, ARIA roles, states, and properties are analogous to CSS for assistive technologies.
For screen reader users, ARIA controls the rendering of their non-visual experience.
Incorrect ARIA misrepresents the visual experience, with potentially devastating effects on their corresponding non-visual experience.
Incorrect ARIA misrepresents the intended experience to _*all*_ assistive technology users, with potentially devastating effects.

Many HTML elements have native semantics that map, by default, to implied ARIA semantics (roles).
Other elements specified as having _*No corresponding role*_ do not have implicit ARIA semantics.
Although they still have meaning it's not provided by ARIA.
In order for assistive technologies to predictably represent the context and behavior of these elements (UI controls),
these implicit semantics should not be overridden as defined in the [ARIA in HTML - Document conformance requirements for use of ARIA attributes in HTML](https://www.w3.org/TR/html-aria/#docconformance) specification.
It is therefore recommended that developers only add a role attribute to a semantically neutral and allowed HTML element such as a `<div>` or `<span>`, rather than incorrectly attempting to override the semantics of the detected element.
No ARIA is better than bad ARIA for assistive technology users.

<!-- the "detected element" and the "unallowed semantics" will be displayed in the rule message above, so the paragraph assumes the reader will have understand that in context -->
When elements are assigned a ARIA `role`, there are required attributes for that role. These attributes represent states and properties of the element. The ARIA attributes accept a specific set of tokens as values along with implicit values termed as ‘default’ when no values are indicated. The correct value of the attribute must be specified as it dictates the behavior of the control and is used by the user agent (Browsers) to process the behavior of the control as prescribed.

<!-- This is where the code snippet is injected -->
<div id="locSnippet"></div>

### What to do

* If a native HTML element fits the intended behavior, use that instead of adding ARIA markup;
* **Or**, update the allowed attributes on the element using the guidance in the [Document conformance requirements for use of "ARIA" attributes in HTML](https://www.w3.org/TR/html-aria/#docconformance) section of
the ARIA in HTML specification.
This reference provides details of allowed ARIA markup and when _*not*_ to use them on native HTML elements.
* Provide a valid value for the attribute defined on the element, using the ARIA specification as a guide.

For example, the following paragraph element defines an `aria-live` property with a valid value of `"polite"`.

```
<p aria-live="polite">Live region content.</p>
```

</script></mark-down>
<!-- End main panel -->
Expand All @@ -80,14 +70,13 @@ <h3 id="ruleMessage"></h3>

### About this requirement

* [IBM 4.1.2 Name, Role, Value](https://www.ibm.com/able/requirements/requirements/#4_1_2)
* [ARIA in HTML - Document conformance requirements for use of ARIA attributes in HTML](https://www.w3.org/TR/html-aria/#docconformance)
* [ARIA authoring practices guide](https://www.w3.org/WAI/ARIA/apg/)
* [IBM 4.1.2 Name, Role, Value](https://www.ibm.com/able/requirements/requirements/#4_1_2)
* [ARIA specification - States and Properties](https://www.w3.org/TR/wai-aria-1.2/#introstates)

### Who does this affect?

* People using a screen reader, including blind, low vision and neurodivergent people
* People using other assistive technologies that expose accessibility information
* People with dexterity impairment using voice control

</script></mark-down>
<!-- End side panel -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,4 @@ <h3 id="ruleMessage"></h3>
</div>
</div>
</body>
</html>
</html>
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,4 @@ <h3 id="ruleMessage"></h3>
</div>
</div>
</body>
</html>
</html>
2 changes: 1 addition & 1 deletion accessibility-checker-engine/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
],
exclude: [
//Disable - due to a defect that needs to be addressed regarding visibility.
'test/v2/checker/accessibility/rules/WCAG20_A_HasText_ruleunit/A-hasTextEmbedded.html'
'test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-hasTextEmbedded.html'
],

frameworks: ['jasmine'],
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/karmaaction.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ module.exports = (config) => {
],
exclude: [
//Disable - due to a defect that needs to be addressed regarding visibility.
'test/v2/checker/accessibility/rules/WCAG20_A_HasText_ruleunit/A-hasTextEmbedded.html'
'test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-hasTextEmbedded.html'
],

frameworks: ['jasmine'],
Expand Down
270 changes: 135 additions & 135 deletions accessibility-checker-engine/legacy/wrapper-node.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,162 +17,162 @@
var ace = module.exports;
var IBMa = module.exports = {};
var mapRuleToG = IBMa.mapRuleToG = {
"RPT_List_Misuse": "3",
"RPT_Marquee_Trigger": "5",
"RPT_Headers_FewWords": "7",
"WCAG20_Input_ExplicitLabelImage": "10",
"RPT_Img_UsemapValid": "11",
"WCAG20_Object_HasText": "20",
"WCAG20_Applet_HasAlt": "21",
"RPT_Media_AudioTrigger": "24",
"RPT_Blockquote_HasCite": "25",
"RPT_Meta_Refresh": "33",
"WCAG20_Frame_HasTitle": "39",
"WCAG20_Input_ExplicitLabel": "41",
"RPT_Media_AltBrief": "99",
"WCAG20_A_TargetAndText": "112",
"WCAG20_Area_HasAlt": "240",
"list_structure_proper": "3",
"marquee_elem_avoid": "5",
"heading_markup_misuse": "7",
"imagebutton_alt_exists": "10",
"img_ismap_misuse": "11",
"object_text_exists": "20",
"applet_alt_exists": "21",
"media_audio_transcribed": "24",
"blockquote_cite_exists": "25",
"meta_refresh_delay": "33",
"frame_title_exists": "39",
"input_label_exists": "41",
"media_alt_brief": "99",
"a_target_warning": "112",
"area_alt_exists": "240",
"RPT_Media_ImgColorUsage": "245",
"WCAG20_Meta_RedirectZero": "254",
"meta_redirect_optional": "254",
"element_attribute_deprecated": "256",
"text_quoted_correctly": "263",
"RPT_Elem_EventMouseAndKey": "269",
"WCAG20_Doc_HasTitle": "273",
"RPT_Block_ShouldBeHeading": "322",
"WCAG20_Form_HasSubmit": "324",
"RPT_Elem_UniqueId": "377",
"RPT_Font_ColorInForm": "394",
"RPT_Label_UniqueFor": "398",
"RPT_Img_AltCommonMisuse": "453",
"RPT_Img_LongDescription2": "454",
"WCAG20_Img_HasAlt": "455",
"RPT_Style_BackgroundImage": "456",
"RPT_Pre_ASCIIArt": "458",
"RPT_Media_VideoReferenceTrigger": "511",
"RPT_Media_AudioVideoAltFilename": "460",
"RPT_Style_ColorSemantics1": "466",
"WCAG20_Select_HasOptGroup": "467",
"RPT_List_UseMarkup": "468",
"RPT_Script_OnclickHTML1": "470",
"WCAG20_Table_Structure": "471",
"element_mouseevent_keyboard": "269",
"page_title_exists": "273",
"text_block_heading": "322",
"form_submit_button_exists": "324",
"element_id_unique": "377",
"form_font_color": "394",
"form_label_unique": "398",
"img_alt_misuse": "453",
"img_longdesc_misuse": "454",
"img_alt_valid": "455",
"style_background_decorative": "456",
"asciiart_alt_exists": "458",
"media_track_available": "511",
"media_alt_exists": "460",
"style_color_misuse": "466",
"select_options_grouped": "467",
"list_markup_review": "468",
"script_onclick_misuse": "470",
"table_structure_misuse": "471",
"WCAG20_Img_AltTriggerNonDecorative": "473",
"WCAG20_Blink_AlwaysTrigger": "478",
"RPT_Blink_CSSTrigger1": "479",
"RPT_Html_SkipNav": "481",
"RPT_Title_Valid": "484",
"RPT_Header_HasContent": "488",
"WCAG20_Html_HasLang": "490",
"WCAG20_Form_TargetAndText": "491",
"WCAG20_A_HasText": "495",
"WCAG20_Fieldset_HasLegend": "497",
"RPT_Media_VideoObjectTrigger": "501",
"RPT_Text_SensoryReference": "502",
"RPT_Embed_AutoStart": "503",
"RPT_Style_HinderFocus1": "506",
"WCAG20_Img_LinkTextNotRedundant": "1000",
"blink_elem_deprecated": "478",
"blink_css_review": "479",
"html_skipnav_exists": "481",
"page_title_valid": "484",
"heading_content_exists": "488",
"html_lang_exists": "490",
"form_interaction_review": "491",
"a_text_purpose": "495",
"fieldset_legend_valid": "497",
"media_live_captioned": "501",
"text_sensory_misuse": "502",
"media_autostart_controllable": "503",
"style_focus_visible": "506",
"img_alt_redundant": "1000",
"RPT_Style_ExternalStyleSheet": "1073",
// "RPT_Header_Trigger": "1002",
"RPT_Script_OnclickHTML2": "1007",
"WCAG20_Table_CapSummRedundant": "1011",
"WCAG20_Input_LabelBefore": "1017",
"WCAG20_Input_LabelAfter": "1018",
"WCAG20_Embed_HasNoEmbed": "1020",
"WCAG20_Table_Scope_Valid": "1025",
"WCAG20_Img_TitleEmptyWhenAltNull": "1027",
"WCAG20_Input_InFieldSet": "1028",
"WCAG20_Input_RadioChkInFieldSet": "1029",
"WCAG20_Select_NoChangeAction": "1035",
"WCAG20_Input_HasOnchange": "1050",
"RPT_Embed_HasAlt": "1051",
"Valerie_Noembed_HasContent": "1052",
"Valerie_Caption_HasContent": "1053",
"Valerie_Caption_InTable": "1054",
"Valerie_Label_HasContent": "1055",
"Valerie_Elem_DirValid": "1056",
"Valerie_Frame_SrcHtml": "1057",
"Valerie_Table_DataCellRelationships": "1059",
"RPT_Table_LayoutTrigger": "1060",
"RPT_Table_DataHeadingsAria": "1061",
"WCAG20_Label_RefValid": "1062",
"WCAG20_Elem_UniqueAccessKey": "1063",
"WCAG20_Script_FocusBlurs": "1064",
"HAAC_Img_UsemapAlt": "1067",
"WCAG20_Text_Emoticons": "1068",
"WCAG20_Style_BeforeAfter": "1069",
"script_onclick_avoid": "1007",
"table_summary_redundant": "1011",
"input_label_before": "1017",
"input_label_after": "1018",
"embed_noembed_exists": "1020",
"table_scope_valid": "1025",
"img_alt_null": "1027",
"input_fields_grouped": "1028",
"input_checkboxes_grouped": "1029",
"script_select_review": "1035",
"input_onchange_review": "1050",
"embed_alt_exists": "1051",
"noembed_content_exists": "1052",
"table_caption_empty": "1053",
"table_caption_nested": "1054",
"label_content_exists": "1055",
"dir_attribute_valid": "1056",
"frame_src_valid": "1057",
"table_headers_related": "1059",
"table_layout_linearized": "1060",
"table_headers_exists": "1061",
"label_ref_valid": "1062",
"element_accesskey_unique": "1063",
"script_focus_blur_review": "1064",
"imagemap_alt_exists": "1067",
"emoticons_alt_exists": "1068",
"style_before_after_review": "1069",
"text_whitespace_valid": "1070",
"Rpt_Aria_ValidRole": "1074",
"Rpt_Aria_ValidPropertyValue": "1076",
"Rpt_Aria_ValidIdRef": "1077",
"Rpt_Aria_RequiredProperties": "1079",
"Rpt_Aria_EmptyPropertyValue": "1082",
"Rpt_Aria_ValidProperty": "1083",
"Rpt_Aria_InvalidTabindexForActivedescendant": "1084",
"Rpt_Aria_MissingFocusableChild": "1086",
"Rpt_Aria_MissingKeyboardHandler": "1087",
"WCAG20_Img_PresentationImgHasNonNullAlt": "1090",
"Rpt_Aria_MultipleSearchLandmarks": "1097",
"Rpt_Aria_MultipleApplicationLandmarks": "1099",
"Rpt_Aria_ApplicationLandmarkLabel": "1100",
"Rpt_Aria_MultipleDocumentRoles": "1101",
"aria_role_allowed": "1074",
"aria_attribute_value_valid": "1076",
"aria_id_unique": "1077",
"aria_attribute_required": "1079",
"aria_attribute_exists": "1082",
"aria_attribute_allowed": "1083",
"aria_activedescendant_tabindex_valid": "1084",
"aria_child_tabbable": "1086",
"aria_keyboard_handler_exists": "1087",
"img_alt_decorative": "1090",
"aria_search_label_unique": "1097",
"aria_application_label_unique": "1099",
"aria_application_labelled": "1100",
"aria_document_label_unique": "1101",
"WCAG20_Label_TargetInvisible": "1112",
"HAAC_Video_HasNoTrack": "1117",
"HAAC_Audio_Video_Trigger": "1119",
"caption_track_exists": "1117",
"media_keyboard_controllable": "1119",
"HAAC_Input_HasRequired": "1124",
"HAAC_Aria_ImgAlt": "1128",
"HAAC_BackgroundImg_HasTextOrTitle": "1132",
"HAAC_Accesskey_NeedLabel": "1140",
"aria_img_labelled": "1128",
"img_alt_background": "1132",
"element_accesskey_labelled": "1140",
"aria_attribute_conflict": "1141",
"HAAC_Canvas": "1143",
"HAAC_Figure_label": "1144",
"HAAC_Input_Placeholder": "1145",
"RPT_Form_ChangeEmpty": "1147",
"IBMA_Color_Contrast_WCAG2AA": "1148",
"IBMA_Color_Contrast_WCAG2AA_PV": "1149",
"WCAG20_Body_FirstASkips_Native_Host_Sematics": "1150",
"WCAG20_Body_FirstAContainsSkipText_Native_Host_Sematics": "1151",
"canvas_content_described": "1143",
"figure_label_exists": "1144",
"input_placeholder_label_visible": "1145",
"form_submit_review": "1147",
"text_contrast_sufficient": "1148",
"text_contrast_sufficient_PV": "1149",
"skip_main_exists": "1150",
"skip_main_described": "1151",
"aria_child_valid": "1152",
"Rpt_Aria_RequiredParent_Native_Host_Sematics": "1153",
"Rpt_Aria_EventHandlerMissingRole_Native_Host_Sematics": "1154",
"Rpt_Aria_WidgetLabels_Implicit": "1156",
"Rpt_Aria_OrphanedContent_Native_Host_Sematics": "1157",
"Rpt_Aria_RegionLabel_Implicit": "1158",
"Rpt_Aria_MultipleMainsVisibleLabel_Implicit": "1159",
"Rpt_Aria_MultipleBannerLandmarks_Implicit": "1160",
"Rpt_Aria_MultipleComplementaryLandmarks_Implicit": "1161",
"Rpt_Aria_MultipleContentinfoLandmarks_Implicit": "1162",
"Rpt_Aria_MultipleFormLandmarks_Implicit": "1163",
"Rpt_Aria_MultipleNavigationLandmarks_Implicit": "1164",
"Rpt_Aria_ComplementaryLandmarkLabel_Implicit": "1165",
"Rpt_Aria_MultipleArticleRoles_Implicit": "1166",
"aria_parent_required": "1153",
"aria_eventhandler_role_valid": "1154",
"aria_widget_labelled": "1156",
"aria_content_in_landmark": "1157",
"aria_region_labelled": "1158",
"aria_main_label_visible": "1159",
"aria_banner_label_unique": "1160",
"aria_complementary_label_unique": "1161",
"aria_contentinfo_label_unique": "1162",
"aria_form_label_unique": "1163",
"aria_navigation_label_unique": "1164",
"aria_complementary_label_visible": "1165",
"aria_article_label_unique": "1166",
"Rpt_Aria_ArticleRoleLabel_Implicit": "1167",
"Rpt_Aria_MultipleGroupRoles_Implicit": "1168",
"Rpt_Aria_GroupRoleLabel_Implicit": "1169",
"Rpt_Aria_MultipleContentinfoInSiblingSet_Implicit": "1170",
"Rpt_Aria_OneBannerInSiblingSet_Implicit": "1172",
"Rpt_Aria_ContentinfoWithNoMain_Implicit": "1173",
"Rpt_Aria_ComplementaryRequiredLabel_Implicit": "1174",
"Rpt_Aria_MultipleRegionsUniqueLabel_Implicit": "1176",
"IBMA_Focus_Tabbable": "1177",
"IBMA_Focus_MultiTab": "1178",
"RPT_Style_Trigger2": "1180",
"Rpt_Aria_MultipleMainsRequireLabel_Implicit_2": "1182",
"HAAC_Media_DocumentTrigger2": "1183",
"HAAC_Aria_ErrorMessage": "1184",
"HAAC_List_Group_ListItem": "1185",
"HAAC_ActiveDescendantCheck": "1186",
"HAAC_Application_Role_Text": "1187",
"Rpt_Aria_MultipleToolbarUniqueLabel": "1188",
"aria_contentinfo_single": "1170",
"aria_banner_single": "1172",
"aria_contentinfo_misuse": "1173",
"aria_complementary_labelled": "1174",
"aria_region_label_unique": "1176",
"widget_tabbable_exists": "1177",
"widget_tabbable_single": "1178",
"style_highcontrast_visible": "1180",
"aria_main_label_unique": "1182",
"download_keyboard_controllable": "1183",
"error_message_exists": "1184",
"list_children_valid": "1185",
"aria_activedescendant_valid": "1186",
"application_content_accessible": "1187",
"aria_toolbar_label_unique": "1188",
"HAAC_Combobox_ARIA_11_Guideline": "1193",
"HAAC_Combobox_Must_Have_Text_Input": "1194",
"HAAC_Combobox_DOM_Focus": "1195",
"HAAC_Combobox_Autocomplete": "1196",
"HAAC_Combobox_Autocomplete_Invalid": "1197",
"HAAC_Combobox_Expanded": "1198",
"HAAC_Combobox_Popup": "1199",
"WCAG21_Style_Viewport": "1200",
"WCAG21_Label_Accessible": "1202",
"WCAG21_Input_Autocomplete": "1203",
"WCAG20_Input_VisibleLabel": "1204"
"style_viewport_resizable": "1200",
"label_name_visible": "1202",
"input_autocomplete_valid": "1203",
"input_label_visible": "1204"
}

IBMa.checker = new ace.Checker();
Expand Down
Loading

0 comments on commit cef6c8b

Please sign in to comment.