Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed bug in Regen constrained generation #75

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

marmg
Copy link
Collaborator

@marmg marmg commented Feb 20, 2024

Status Type ⚠️ Core Change Issue
Ready Bug No #73

Problem

ValueError: prefix_allowed_tokens_fn with new version of transformers

Solution

When finished generation return EOS token instead of empty list.

Closes #73

@marmg marmg self-assigned this Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf8fa81) 94.11% compared to head (7d4abf4) 94.11%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files          84       84           
  Lines        3568     3571    +3     
=======================================
+ Hits         3358     3361    +3     
  Misses        210      210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marmg marmg merged commit d16783e into main Feb 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ValueError: prefix_allowed_tokens_fn with new version of transformers package
1 participant