Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix bug in relations renderer #65

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

marmg
Copy link
Collaborator

@marmg marmg commented Sep 1, 2023

Status Type ⚠️ Core Change Issue
Ready Bug No #64

Problem

IndexError while visualizing results without entities extracted in the "rel" mode:

Solution

Fix the render tools for relations when no entities extracted.

Closes #64

Signed-off-by: Marcos Martinez <[email protected]>
@marmg marmg self-assigned this Sep 1, 2023
@marmg marmg merged commit 3532701 into main Sep 1, 2023
3 of 4 checks passed
@marmg marmg deleted the fix/visualization-relations branch September 1, 2023 13:38
marmg added a commit that referenced this pull request Sep 5, 2023
marmg added a commit that referenced this pull request Sep 5, 2023
* ✨ Added KnowledgeExtractor. Added KnowGL

Signed-off-by: Marcos Martinez <[email protected]>

* ✅ Created tests for KnowledgeExtractor

Signed-off-by: Marcos Martinez <[email protected]>

* 📝 Added documentation of Knowledge Extractor component

Signed-off-by: Marcos Martinez <[email protected]>

* ♻️ Created mappings module from spans_to_ functions of Regen

Signed-off-by: Marcos Martinez <[email protected]>

* 🐛 Fix bug in labels in KnowGL

Signed-off-by: Marcos Martinez <[email protected]>

* 📝 Updated README

Signed-off-by: Marcos Martinez <[email protected]>

* 🎨 Fix flake

Signed-off-by: Marcos Martinez <[email protected]>

* 📝 Change test name

Signed-off-by: Marcos Martinez <[email protected]>

* 🐛 Fix bug in relations renderer (#65)

Signed-off-by: Marcos Martinez <[email protected]>

* Fix/tests (#66)

* ✅🐛 Improve tests performance. Fix minor bugs related

Signed-off-by: Marcos Martinez <[email protected]>

* ✅ Added download models

Signed-off-by: Marcos Martinez <[email protected]>

* 🎨 Fixed flake

Signed-off-by: Marcos Martinez <[email protected]>

* 🎨 Fixed flake

Signed-off-by: Marcos Martinez <[email protected]>

* Added try/except on load models

Signed-off-by: Marcos Martinez <[email protected]>

* Added try/except on load models

Signed-off-by: Marcos Martinez <[email protected]>

* ✅ Added xfail to tars tests

Signed-off-by: Marcos Martinez <[email protected]>

* ✅ Updated pydantic requirements

Signed-off-by: Marcos Martinez <[email protected]>

* ✅ Added fewrel tests

Signed-off-by: Marcos Martinez <[email protected]>

* ✅ Updated tests

Signed-off-by: Marcos Martinez <[email protected]>

* Revert "✅ Updated tests"

This reverts commit eae7c8c.

Signed-off-by: Marcos Martinez <[email protected]>

---------

Signed-off-by: Marcos Martinez <[email protected]>

---------

Signed-off-by: Marcos Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Error while visualizing results without entities extracted
1 participant