Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add block.LastStableOffset check ,only block.LastStableOffset >0 mean… #981

Closed
wants to merge 1 commit into from

Conversation

xhbpiao
Copy link

@xhbpiao xhbpiao commented Nov 16, 2017

When spending 0.11 kafka, block.LastStableOffset has been -1, so each time you get the data can only be parsed one. Cause serious consumer congestion

@eapache
Copy link
Contributor

eapache commented Nov 16, 2017

Is this the cause of #980?

cc @wladh

@xhbpiao
Copy link
Author

xhbpiao commented Nov 17, 2017

@eapache yes

@xhbpiao
Copy link
Author

xhbpiao commented Nov 17, 2017

I use filebeat to collect the log, But it's official website supports the latest version is 0.10. I have to use 0.11 protocol to parse the message, otherwise it will cause congestion。
May be the result of the reason of filebeat LastStableOffset resolution fail

@wladh
Copy link
Contributor

wladh commented Nov 17, 2017

Actually we can do away with the whole check for now. Since we're always at ReadUncommitted isolation level, the stable offset doesn't matter as we're reading everything.
Also, it's wrong as it should have been performed before returning one messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants