Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make list of brokers available through sarama.Client #813

Merged
merged 3 commits into from
Jan 27, 2017
Merged

make list of brokers available through sarama.Client #813

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56f3f2b
make list of brokers available through sarama.Client
hollow Jan 25, 2017
3276070
do not create sparse array
hollow Jan 25, 2017
b9842b6
hold read lock while reading brokers
hollow Jan 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ type Client interface {
// altered after it has been created.
Config() *Config

// Brokers returns the current set of active brokers as retrieved from cluster metadata.
Brokers() []*Broker

// Topics returns the set of available topics as retrieved from cluster metadata.
Topics() ([]string, error)

Expand Down Expand Up @@ -157,6 +160,16 @@ func (client *client) Config() *Config {
return client.conf
}

func (client *client) Brokers() []*Broker {
client.lock.RLock()
defer client.lock.RUnlock()
brokers := make([]*Broker, 0)
for _, broker := range client.brokers {
brokers = append(brokers, broker)
}
return brokers
}

func (client *client) Close() error {
if client.Closed() {
// Chances are this is being called from a defer() and the error will go unobserved
Expand Down