Code

OffsetManager Implementation#461

Code

Merged

eapache merged 24 commits intomasterIBM/sarama:masterfrom offset-managerIBM/sarama:offset-managerCopy head branch name to clipboardAug 24, 2015

+907-1

Commits

Commits on Aug 18, 2015

• First draft implementation of an offset manager

  Show description for e0c0da8
  eapache

  committed
  e0c0da8

  Copy full SHA for e0c0da8

• Track dirty flag in partition-offset-manager

  Show description for 90ba479
  eapache

  committed
  90ba479

  Copy full SHA for 90ba479

• Don't shutdown until the latest offset was successfully committed

  eapache

  committed
  e7d8e17

  Copy full SHA for e7d8e17

• Don't start setting until the initial get succeeds

  Show description for 9e2380c
  eapache

  committed
  9e2380c

  Copy full SHA for 9e2380c

• Only add dirty subscriptions to the request

  Show description for b4fb5b7
  eapache

  committed
  b4fb5b7

  Copy full SHA for b4fb5b7

• Fix abort()

  Show description for 9d4ca02
  eapache

  committed
  9d4ca02

  Copy full SHA for 9d4ca02

• Fix some error return codes

  

  aaronkavlie-wf

  authored and

  eapache

  committed
  e98389a

  Copy full SHA for e98389a

• Skip clean subscriptions when parsing responses

  eapache

  committed
  84abfe4

  Copy full SHA for 84abfe4

• Start offset manager tests

  Show description for 1d96533
  

  aaronkavlie-wf

  authored and

  eapache

  committed
  1d96533

  Copy full SHA for 1d96533

• Test handling of commit errors when an offset is set

  

  aaronkavlie-wf

  authored and

  eapache

  committed
  5f0a997

  Copy full SHA for 5f0a997

• Test of one fetchInitialOffset error

  Show description for 71aee66
  

  aaronkavlie-wf

  authored and

  eapache

  committed
  71aee66

  Copy full SHA for 71aee66

• Break out repeated code to separate init function

  

  aaronkavlie-wf

  authored and

  eapache

  committed
  67f88f7

  Copy full SHA for 67f88f7

• Tests of error responses in fetchInitialOffset

  

  aaronkavlie-wf

  authored and

  eapache

  committed
  132f582

  Copy full SHA for 132f582

• Test to covert abort process.

  Show description for 147e2fe
  

  aaronkavlie-wf

  authored and

  eapache

  committed
  147e2fe

  Copy full SHA for 147e2fe

• Close open connections; refine and clean up code.

  

  aaronkavlie-wf

  authored and

  eapache

  committed
  50afd11

  Copy full SHA for 50afd11

• Complete coverage of flushToBroker()

  

  aaronkavlie-wf

  authored and

  eapache

  committed
  2ad9fa7

  Copy full SHA for 2ad9fa7

• Misc. small changes to address PR feedback

  Show description for 33f2f9f
  

  aaronkavlie-wf

  authored and

  eapache

  committed
  33f2f9f

  Copy full SHA for 33f2f9f

Commits on Aug 19, 2015

• Improve godoc of PartitionOffsetManager interface

  wvanbergen

  committed
  1e19f5c

  Copy full SHA for 1e19f5c

• Add Close() error to OffsetManager interface

  wvanbergen

  committed
  1e8c4f2

  Copy full SHA for 1e8c4f2

• Merge pull request #518 from Shopify/offset-manager-close

  Show description for de8e312
  wvanbergen

  committed
  de8e312

  Copy full SHA for de8e312

Commits on Aug 21, 2015

• OffsetManager: make initial offset configurable

  wvanbergen

  committed
  5109f97

  Copy full SHA for 5109f97

• Add a functional test for the offset manager.

  wvanbergen

  committed
  e8c3c16

  Copy full SHA for e8c3c16

• Deregister a partition offset manager in the OffsetManager when it is done, so we can register a new one later.

  wvanbergen

  committed
  0ae0505

  Copy full SHA for 0ae0505

• Merge pull request #520 from Shopify/offset-manager-initial

  Show description for 4c0d6fc
  wvanbergen

  committed
  4c0d6fc

  Copy full SHA for 4c0d6fc