Process results of a single fetch request in parallel #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| c1, err := master.ConsumePartition("my_topic", 1, 0) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
|
|
||
| time.Sleep(50 * time.Millisecond) |
eapache
force-pushed
the
process-partitions-in-parallel
branch
from
77ac8a6 to
aadea7d
Compare
And abandon partitions that take too long (e.g. because the client is stuck).
eapache
force-pushed
the
process-partitions-in-parallel
branch
from
aadea7d to
8196ab1
Compare
|
I think I have a better idea (we'll see once I've actually written it :P) but this was enlightening regardless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And abandon partitions that take too long (e.g. because the
clientuser-space reading goroutine is stuck).@wvanbergen this is a draft attempt at fixing #325 but it kind of sucks. The bulk of the diff is just moving the
handleResponsemethod from being on the brokerConsumer to being on the partitionConsumer (split out into #387)