async_producer: clarify ProducerMessage Timestamp doc
#1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
The `Timestamp` field was introduced in IBM#678 and at this point was only set by the broker. Subsequent to this, the changes described in [KIP-32] were implemented, allowing the `Timestamp` of the message to be set by a producer when the broker was configured to use `CreateTime`. This commit updates the doc on the ProducerMessage struct to reflect that depending on which of the `CreateTime` and `LogAppendTime` modes are active, the `Timestamp` can be meaningfully set by either the request or the response. [KIP-32]: https://cwiki.apache.org/confluence/display/KAFKA/KIP-32+-+Add+timestamps+to+Kafka+message
kjgorman
force-pushed
the
producer-message-timestamp-documentation
branch
from
cb3c9ad to
1889f36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Timestampfield was introduced in #678 and at this point was only set bythe broker.
Subsequent to this, the changes described in KIP-32 were implemented,
allowing the
Timestampof the message to be set by a producer when thebroker was configured to use
CreateTime.This commit updates the doc on the ProducerMessage struct to reflect that
depending on which of the
CreateTimeandLogAppendTimemodes are active,the
Timestampcan be meaningfully set by either the request or theresponse.