Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document recordbatch offset changes from #1032 #1056

Merged
merged 1 commit into from
Feb 16, 2018

Conversation

kenschneider18
Copy link
Contributor

@pkedy and I thought it might not be a bad idea to document the change we made for issue #1032

@eapache
Copy link
Contributor

eapache commented Feb 16, 2018

Thanks!

@eapache eapache merged commit 3d1fae1 into IBM:master Feb 16, 2018
@pkedy
Copy link
Contributor

pkedy commented Feb 16, 2018

For the record, @kenschneider18 and I worked together on #1032/#1041 and he also deserves credit for this fix. Unfortunately, our corporate GH policy only allowed me to submit the PR. Shout out also to @superfell, @buyology, @bobrik and others who did a lot of the difficult research/legwork. I wish GH would give "kudos" to issue creators/collaborators. In the NBA, they count assists in addition to points scored!

@eapache
Copy link
Contributor

eapache commented Feb 16, 2018

Dunno what your corporate policy is on commit messages, but git has no requirement that the sign-off footers (Signed-off-by: Super Developer <[email protected]>) actually use Signed-off-by. A lot of people like to put extra references in there with other keys, e.g.

Usual commit message etc etc.

Collaboration-with: Ken Schneider <...>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants