-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider switching default Kafka version to at least 2.1 #2408
Comments
@ijuma thanks for getting in touch and the great writeup of the KIP and 2.1 sounds like a good baseline. Bumping the default KafkaVersion isn't a problem at all, but as you note our protocol version implementations aren't in sync with the Java client anyway I'd suggest we sync this up with bumping Sarama to a 2.x and we can work on ensuring that we have implemented all of the protocol baselines to match the Java client at 2.1 (V7 MetadataRequest etc.) and to match what an ApiVersionRequest to a Kafka 2.1 broker returns |
@dnwe that sounds great if the project has the cycles to update all of the protocol baselines as well. |
Hi @dnwe. Is Sarama 2.x on the horizon or would it be better to do something more incremental in the meantime to avoid a situation where Sarama users with reasonably recent clients break by default with Apache Kafka 4.0? |
@ijuma whilst on holiday I spent a bit of time looking into the minimum we'd need to do in order to meet this i.e., if we change the default baked version to sarama.V2.1.0.0 then a) what default request versions do we support, but are not sending correctly atm and b) what protocol versions are not even implemented that need implementing so this is WIP |
Contributes-to: #2408 Signed-off-by: Dominic Evans <[email protected]>
Contributes-to: #2408 Signed-off-by: Dominic Evans <[email protected]>
Contributes-to: #2408 Signed-off-by: Dominic Evans <[email protected]>
Contributes-to: #2408 Signed-off-by: Dominic Evans <[email protected]>
Contributes-to: #2408 Signed-off-by: Dominic Evans <[email protected]>
Contributes-to: #2408 Signed-off-by: Dominic Evans <[email protected]>
Contributes-to: #2408 Signed-off-by: Dominic Evans <[email protected]>
Awesome to see the progress @dnwe! |
@ijuma 😀 Is there a branch or patchset anywhere for apache/kafka that has a draft implementation of KAFKA-14560? It would be useful if we could configure a broker and set the minimum APIKey versions somehow so we can test ourselves out against it |
@dnwe not yet, I'll let you know once that exists. |
This comment was marked as outdated.
This comment was marked as outdated.
Thank you for taking the time to raise this issue. However, it has not had any activity on it in the past 90 days and will be closed in 30 days if no updates occur. |
The 4.0 branch of Apache Kafka now contains the KIP-896 change: |
The default Kafka version was set to
1.0
via #1787. This was a huge improvement over the previous default and the hope was that proper api versions support would be supported some time later.2.5 years have passed and the default remains 1.0 if I understand correctly (please correct me if this is wrong).
I am working on a KIP to remove older protocol versions in Apache Kafka 4.0 and the proposed baseline is Apache Kafka 2.1:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-896%3A+Remove+old+client+protocol+API+versions+in+Kafka+4.0
The KIP is still under discussion (i.e. it hasn't been approved yet), but I wanted to:
Thanks!
The text was updated successfully, but these errors were encountered: