Consumer: reduce ticker allocations

IBM · Feb 4, 2018 · d7428ad · d7428ad
1 parent 0f4f8ca
commit d7428ad
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/consumer.go b/consumer.go
@@ -442,11 +442,11 @@ func (child *partitionConsumer) HighWaterMarkOffset() int64 {
 func (child *partitionConsumer) responseFeeder() {
 	var msgs []*ConsumerMessage
 	msgSent := false
+	expiryTicker := time.NewTicker(child.conf.Consumer.MaxProcessingTime)
 
 feederLoop:
 	for response := range child.feeder {
 		msgs, child.responseResult = child.parseResponse(response)
-		expiryTicker := time.NewTicker(child.conf.Consumer.MaxProcessingTime)
 
 		for i, msg := range msgs {
 		messageSelect:
@@ -471,10 +471,10 @@ feederLoop:
 			}
 		}
 
-		expiryTicker.Stop()
 		child.broker.acks.Done()
 	}
 
+	expiryTicker.Stop()
 	close(child.messages)
 	close(child.errors)
 }