Skip to content

Commit

Permalink
Merge pull request #835 from Shopify/tweak-close-docs
Browse files Browse the repository at this point in the history
Tweak documentation of Close/AsyncClose methods
  • Loading branch information
eapache authored Feb 28, 2017
2 parents a71bff8 + 8268907 commit 431b10f
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 13 deletions.
17 changes: 8 additions & 9 deletions async_producer.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,16 @@ import (
// scope.
type AsyncProducer interface {

// AsyncClose triggers a shutdown of the producer, flushing any messages it may
// have buffered. The shutdown has completed when both the Errors and Successes
// channels have been closed. When calling AsyncClose, you *must* continue to
// read from those channels in order to drain the results of any messages in
// flight.
// AsyncClose triggers a shutdown of the producer. The shutdown has completed
// when both the Errors and Successes channels have been closed. When calling
// AsyncClose, you *must* continue to read from those channels in order to
// drain the results of any messages in flight.
AsyncClose()

// Close shuts down the producer and flushes any messages it may have buffered.
// You must call this function before a producer object passes out of scope, as
// it may otherwise leak memory. You must call this before calling Close on the
// underlying client.
// Close shuts down the producer and waits for any buffered messages to be
// flushed. You must call this function before a producer object passes out of
// scope, as it may otherwise leak memory. You must call this before calling
// Close on the underlying client.
Close() error

// Input is the input channel for the user to write messages to that they
Expand Down
8 changes: 4 additions & 4 deletions sync_producer.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ type SyncProducer interface {
// SendMessages will return an error.
SendMessages(msgs []*ProducerMessage) error

// Close shuts down the producer and flushes any messages it may have buffered.
// You must call this function before a producer object passes out of scope, as
// it may otherwise leak memory. You must call this before calling Close on the
// underlying client.
// Close shuts down the producer and waits for any buffered messages to be
// flushed. You must call this function before a producer object passes out of
// scope, as it may otherwise leak memory. You must call this before calling
// Close on the underlying client.
Close() error
}

Expand Down

0 comments on commit 431b10f

Please sign in to comment.