Skip to content

Commit

Permalink
Merge pull request #1024 from Shopify/behrooz_Fetch_default
Browse files Browse the repository at this point in the history
changed Fetch.default value from 32KB to 1MB
  • Loading branch information
eapache authored Jan 18, 2018
2 parents d0cc7fe + a1cfcca commit 1abfd98
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions config.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ type Config struct {
// Equivalent to the JVM's `fetch.min.bytes`.
Min int32
// The default number of message bytes to fetch from the broker in each
// request (default 32768). This should be larger than the majority of
// request (default 1MB). This should be larger than the majority of
// your messages, or else the consumer will spend a lot of time
// negotiating sizes and not actually consuming. Similar to the JVM's
// `fetch.message.max.bytes`.
Expand Down Expand Up @@ -292,7 +292,7 @@ func NewConfig() *Config {
c.Producer.Return.Errors = true

c.Consumer.Fetch.Min = 1
c.Consumer.Fetch.Default = 32768
c.Consumer.Fetch.Default = 1024 * 1024
c.Consumer.Retry.Backoff = 2 * time.Second
c.Consumer.MaxWaitTime = 250 * time.Millisecond
c.Consumer.MaxProcessingTime = 100 * time.Millisecond
Expand Down

0 comments on commit 1abfd98

Please sign in to comment.