Fix some http 5.1.1 test failures #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
changed the title
Signed-off-by: Joe Rafaniello <[email protected]>
See: https://github.com/httprb/http/pull/546/files Note, HTTP::Response and HTTP::Request.new take options hashes, not keyword arguments. For ruby 3.0, we should be explicit that we're pashing hashes since our IBMCloudSdkCore::DetailedResponse.new interface uses kwargs and is therefore confusing. We should probably match the options hash interface since ruby 3.0 treats them differently. Signed-off-by: Joe Rafaniello <[email protected]>
jrafanie
force-pushed
the
fix_http_5_1_1
branch
from
f895f07 to
aee55e6
Compare
pyrooka
approved these changes
Oct 9, 2023
pyrooka
pushed a commit
that referenced
this pull request
Nov 6, 2023
This commit resolves the rubocop warnings mentioned in PR #41 - Test with ruby 2.7, 3.0, 3.1. 2.7 is end of life and all prior are also but we can possibly keep 2.7 supportable for now. See: https://www.ruby-lang.org/en/downloads/branches/ - Upgrade to bundler 2 and rubocop 1.40+ - Fix some obvious rubocop violations - Remove all non-required .rubocop.yml settings to simplify the configuration Signed-off-by: Joe Rafaniello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some test failures with http 5.0 and makes sure they pass with ruby 2.7 and 3.0.