Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 hook should return a v1 result #334

Merged
merged 2 commits into from
Jun 15, 2021
Merged

v1 hook should return a v1 result #334

merged 2 commits into from
Jun 15, 2021

Conversation

sjhx
Copy link
Member

@sjhx sjhx commented Jun 15, 2021

Moving to the v1 webhook not so simple, obviously requires that the response is of the v1 type.

Signed-off-by: Stuart Hayton [email protected]

issue: #215

Copy link
Contributor

@aaroncollins aaroncollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjhx sjhx merged commit c9a1b60 into master Jun 15, 2021
@sjhx sjhx deleted the v1hook branch June 15, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants