Allow anonymous notary access #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This tests successfully with my cluster-local anonymous notary server. |
|
In a few weeks I'll be in a new position where I won't be using Portieris anymore, so if there's any feedback on this PR that I can address to make it more mergeable, please send such |
tim-gp
pushed a commit
to tim-gp/portieris
that referenced
this pull request
Oct 1, 2020
Co-authored-by: Stuart Hayton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow access to anonymous notary servers (those without authentication turned on). I found this to be necessary when running my own notary server for storing signatures of images in ECR.
I did this by suffixing username "" password "" to the end of the real credentials array, and having methods that hit oauth and compose authentication headers be aware of this.
Opening in draft to get feedback on the approach while I'm continuing to test.