-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test and support Helm 3 #89
Comments
molepigeon
added a commit
that referenced
this issue
Apr 20, 2020
* Removed the Hyperkube jobs that created the CRDs, admission webhooks, and default policies, in favour of the native support in Helm 3. * Migrated the CRD definition to apiextensions/v1 * Admission webhook will migrate to admissionregistration/v1 if it is supported, otherwise it stays at v1beta1 With this commit, the chart is no longer compatible with Helm 2, since Helm 2 does not support CRDs in the same way as Helm 3. It also requires Kube 1.16+ for the v1 CRD API. Updated the README to reflect this. #89 Signed-off-by: Michael Hough <[email protected]>
molepigeon
added a commit
that referenced
this issue
Jun 11, 2020
* Removed the Hyperkube jobs that created the CRDs, admission webhooks, and default policies, in favour of the native support in Helm 3. * Migrated the CRD definition to apiextensions/v1 * Admission webhook will migrate to admissionregistration/v1 if it is supported, otherwise it stays at v1beta1 With this commit, the chart is no longer compatible with Helm 2, since Helm 2 does not support CRDs in the same way as Helm 3. It also requires Kube 1.16+ for the v1 CRD API. Updated the README to reflect this. #89 Signed-off-by: Michael Hough <[email protected]>
@molepigeon can we close this now? |
Well I think we can :) |
tim-gp
pushed a commit
to tim-gp/portieris
that referenced
this issue
Oct 1, 2020
* Removed the Hyperkube jobs that created the CRDs, admission webhooks, and default policies, in favour of the native support in Helm 3. * Migrated the CRD definition to apiextensions/v1 * Admission webhook will migrate to admissionregistration/v1 if it is supported, otherwise it stays at v1beta1 With this commit, the chart is no longer compatible with Helm 2, since Helm 2 does not support CRDs in the same way as Helm 3. It also requires Kube 1.16+ for the v1 CRD API. Updated the README to reflect this. IBM#89 Signed-off-by: Michael Hough <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In theory, every chart that's built for Helm 2 should be forward compatible with Helm 3. However, there's some uncertainty about whether the install hooks for installing the policy CRDs will work correctly in Helm 3. We need to know that the chart install works before we can say with confidence that we support Helm 3.
Plus, Helm 3 doesn't have the
--purge
option onhelm delete
, so we'd need to document around that.The text was updated successfully, but these errors were encountered: