Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and support Helm 3 #89

Closed
molepigeon opened this issue Mar 5, 2020 · 2 comments
Closed

Test and support Helm 3 #89

molepigeon opened this issue Mar 5, 2020 · 2 comments

Comments

@molepigeon
Copy link
Member

In theory, every chart that's built for Helm 2 should be forward compatible with Helm 3. However, there's some uncertainty about whether the install hooks for installing the policy CRDs will work correctly in Helm 3. We need to know that the chart install works before we can say with confidence that we support Helm 3.

Plus, Helm 3 doesn't have the --purge option on helm delete, so we'd need to document around that.

molepigeon added a commit that referenced this issue Apr 20, 2020
* Removed the Hyperkube jobs that created the CRDs, admission webhooks, and default policies, in favour of the native support in Helm 3.
* Migrated the CRD definition to apiextensions/v1
* Admission webhook will migrate to admissionregistration/v1 if it is supported, otherwise it stays at v1beta1

With this commit, the chart is no longer compatible with Helm 2, since Helm 2 does not support CRDs in the same way as Helm 3. It also requires Kube 1.16+ for the v1 CRD API. Updated the README to reflect this.

#89

Signed-off-by: Michael Hough <[email protected]>
molepigeon added a commit that referenced this issue Jun 11, 2020
* Removed the Hyperkube jobs that created the CRDs, admission webhooks, and default policies, in favour of the native support in Helm 3.
* Migrated the CRD definition to apiextensions/v1
* Admission webhook will migrate to admissionregistration/v1 if it is supported, otherwise it stays at v1beta1

With this commit, the chart is no longer compatible with Helm 2, since Helm 2 does not support CRDs in the same way as Helm 3. It also requires Kube 1.16+ for the v1 CRD API. Updated the README to reflect this.

#89

Signed-off-by: Michael Hough <[email protected]>
@sjhx
Copy link
Member

sjhx commented Jul 2, 2020

@molepigeon can we close this now?

@sjhx
Copy link
Member

sjhx commented Sep 2, 2020

Well I think we can :)

@sjhx sjhx closed this as completed Sep 2, 2020
tim-gp pushed a commit to tim-gp/portieris that referenced this issue Oct 1, 2020
* Removed the Hyperkube jobs that created the CRDs, admission webhooks, and default policies, in favour of the native support in Helm 3.
* Migrated the CRD definition to apiextensions/v1
* Admission webhook will migrate to admissionregistration/v1 if it is supported, otherwise it stays at v1beta1

With this commit, the chart is no longer compatible with Helm 2, since Helm 2 does not support CRDs in the same way as Helm 3. It also requires Kube 1.16+ for the v1 CRD API. Updated the README to reflect this.

IBM#89

Signed-off-by: Michael Hough <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants