Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix .releaserc format #295

Merged
merged 1 commit into from
Feb 17, 2025
Merged

fix(build): fix .releaserc format #295

merged 1 commit into from
Feb 17, 2025

Conversation

padamstx
Copy link
Member

Fixes the format of the .releaserc file to comply with the semrel docs.

@padamstx padamstx self-assigned this Feb 17, 2025
@padamstx padamstx requested a review from dpopp07 February 17, 2025 22:50
Fixes: arf/planning-sdk-squad#4105

Signed-off-by: Phil Adams <[email protected]>
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Though I would use a "build" commit since we aren't actually releasing any changes to the package. (I know that leaves us on the edge of our seat until the next actual change rolls through 🙂 so up to you).

@padamstx
Copy link
Member Author

Though I would use a "build" commit since we aren't actually releasing any changes to the package. (I know that leaves us on the edge of our seat until the next actual change rolls through 🙂 so up to you).

I thought about that, but decided on a fix commit to force a new patch level, because I want to get these changes "tested" so I can then go ahead and make similar changes in some of the other node projects (template, node sdk, etc.).

@padamstx padamstx merged commit be52706 into main Feb 17, 2025
12 checks passed
@padamstx padamstx deleted the fix-semrel-config branch February 17, 2025 23:09
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants