Skip to content

Commit

Permalink
Merge pull request #25 from IBM/fh-links
Browse files Browse the repository at this point in the history
Add Links rule
  • Loading branch information
frankharkins authored Mar 29, 2023
2 parents d82e072 + f002ec7 commit f7083b1
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 0 deletions.
16 changes: 16 additions & 0 deletions IBMQuantum/Links.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
extends: existence
message: Link names should make sense without context; change "%s" to something more descriptive.
level: suggestion
code: false
scope: link
ignorecase: true
tokens:
- click here
- here
- link
- more
- more information
- page
- read more
- this link
- this page
1 change: 1 addition & 0 deletions features/rules.feature
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Feature: Rules
test.md:27:36:IBMQuantum.Terms:Use 'use' rather than 'utilize'
test.md:27:75:IBMQuantum.CringeWords:Don't use 'end users'
test.md:27:90:IBMQuantum.CringeWords:Don't use 'we encourage you'
test.md:29:12:IBMQuantum.Links:Link names should make sense without context; change "link" to something more descriptive.
"""

Scenario: Use of punctuation
Expand Down
1 change: 1 addition & 0 deletions fixtures/Terms/.vale.ini
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ IBMQuantum.Terms = YES
IBMQuantum.CringeWords = YES
IBMQuantum.Politeness = YES
IBMQuantum.However = YES
IBMQuantum.Links = YES
4 changes: 4 additions & 0 deletions fixtures/Terms/test.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,7 @@ This sentence is however, bad.
Please do not be too polite in your technical writing.

We understand that you may want to utilize these phrases when writing for end users, but we encourage you not to.

This is a [link](www.ibm.com) to IBM's site.

Check out this link to the [IBM website](www.ibm.com).

0 comments on commit f7083b1

Please sign in to comment.