Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILS-247 adjust to envsubst usage #2312

Open
wants to merge 2 commits into
base: scripts-dev
Choose a base branch
from

Conversation

karol-wozniak-ibm
Copy link

What this PR does / why we need it:
to solve https://jsw.ibm.com/browse/ILS-166

Which issue(s) this PR fixes:
Fixes # https://jsw.ibm.com/browse/ILS-247

Special notes for your reviewer:
ILS-247-Tests.pdf

@ibm-ci-bot
Copy link
Collaborator

Hi @karol-wozniak-ibm. Thanks for your PR.

I'm waiting for a IBM member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karol-wozniak-ibm, pgodowski
Once this PR has been reviewed and has the lgtm label, please assign ycshen1010 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pgodowski
Copy link
Contributor

@bitscuit Can u pls review/merge?

- ports:
- protocol: TCP
port: <$TargetPort> # TargetPort from the DEFAULT KUBERNETES SERVICE
- ports:S
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
May I ask that do we expect this S in line 16?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants