added flink turbonomic orm files #2297
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: infantsabinIBM The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @infantsabinIBM! It looks like this is your first PR to IBM/ibm-common-service-operator 🎉 |
|
Hi @infantsabinIBM. Thanks for your PR. I'm waiting for a IBM member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Infant Sabin A <[email protected]>
infantsabinIBM
force-pushed
the
flink-turbonomic-change
branch
from
c43fbfa to
28a1c54
Compare
| kind: OperatorResourceMapping | ||
| metadata: | ||
| name: flink-jobmanager-orm | ||
| namespace: $namespace |
There was a problem hiding this comment.
Have we standardized the namespace placeholder?
There was a problem hiding this comment.
Unofficially, everyone so far has it as $namespace. But let's clarify this now to avoid confusion, and to make the script easier.
Some suggestions would be:
{{ placeholder_ns }}__placeholder_ns__<placeholder_ns>
I prefer the first one {{ }} because it's used in other areas with templating, such as go templates.
| owner: | ||
| apiVersion: operators.coreos.com/v1alpha1 | ||
| kind: ClusterServiceVersion | ||
| name: ibm-opencontent-flink.v2.0.6 |
There was a problem hiding this comment.
We want to avoid hardcoding CSV names. See parent epic for the label matching instead.
There was a problem hiding this comment.
Let's remove the operator ORM for the time being so it's not accidentally applied by customers until we have it fully supported, i.e. update our CSVs with a reliable label for label matching.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/64871
Special notes for your reviewer:
Yes