Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/csi 3417 add full generation for roles editing #220

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ help: ## Display this help.

##@ Development

manifests: controller-gen kustomize## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects.
manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects.
$(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=ibm-block-csi-operator webhook paths="./..." output:crd:artifacts:config=config/crd/bases
$(KUSTOMIZE) build config/crd/ -o config/crd/bases/csi.ibm.com_ibmblockcsis.yaml
hack/add-lables-to-yamls.sh

generate: controller-gen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..."
Expand Down Expand Up @@ -80,7 +80,7 @@ test: check-generated-manifests update
ginkgo -r -v -skipPackage tests

.PHONY: update
update: kustomize
update:
hack/update-all.sh
oriyarde marked this conversation as resolved.
Show resolved Hide resolved

.PHONY: check-generated-manifests
Expand Down
6 changes: 6 additions & 0 deletions build/ci/Dockerfile.unittest
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ RUN go get github.com/onsi/ginkgo/[email protected] \
&& make kustomize \
&& make controller-gen

ARG YQ_VERSION=v4.13.5
ARG BINARY=yq_linux_386
RUN YQ_BINARY=$(if [ "$(uname -m)" = "x86_64" ]; then echo "yq_linux_amd64"; else echo "yq_linux_$(uname -m)" ; fi) \
&& wget https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/${YQ_BINARY} -O /usr/bin/yq \
oriyarde marked this conversation as resolved.
Show resolved Hide resolved
&& chmod +x /usr/bin/yq

COPY . .

CMD ["make", "test"]
1,937 changes: 969 additions & 968 deletions config/crd/bases/csi.ibm.com_ibmblockcsis.yaml

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions config/crd/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
resources:
- bases/csi.ibm.com_ibmblockcsis.yaml
#+kubebuilder:scaffold:crdkustomizeresource

patchesStrategicMerge:
- patches/labels_patch.yaml
4 changes: 0 additions & 4 deletions config/rbac/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,3 @@ resources:
- service_account.yaml
- role.yaml
- role_binding.yaml


patchesStrategicMerge:
- role_labels_patch.yaml
Loading