Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): improve go core's debug logging #227

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

padamstx
Copy link
Member

This commit adds some debug logging in various
components, and also modifies some tests so that
it's easy to enable debug logging when running
individual sets of tests.

@padamstx padamstx requested a review from dpopp07 August 16, 2024 20:59
@padamstx padamstx self-assigned this Aug 16, 2024
@padamstx padamstx requested a review from pyrooka August 21, 2024 22:34
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left 2 minor suggestions, otherwise it looks pretty good!

core/config_utils_test.go Outdated Show resolved Hide resolved
core/base_service.go Outdated Show resolved Hide resolved
This commit adds some debug logging in various
components, and also modifies some tests so that
it's easy to enable debug logging when running
individual sets of tests.

Signed-off-by: Phil Adams <[email protected]>
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

core/base_service.go Show resolved Hide resolved
@padamstx padamstx merged commit f0f3237 into main Sep 3, 2024
4 checks passed
@padamstx padamstx deleted the debug-logging branch September 3, 2024 16:04
ibm-devx-sdk pushed a commit that referenced this pull request Sep 3, 2024
## [5.17.5](v5.17.4...v5.17.5) (2024-09-03)

### Bug Fixes

* **logging:** improve go core's debug logging ([#227](#227)) ([f0f3237](f0f3237))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.17.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants