Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new standardized structures for errors #5169

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

dpopp07
Copy link
Contributor

@dpopp07 dpopp07 commented Mar 4, 2024

feat: add new TerraformProblem type for identifiable errors

This adds baseline support for a new error structure, created specifically
for Terraform code.

cc @hkantare @astha-jain - this is part of the identifiable error work we have been discussing the last couple of months. It enables the new error formats for some of the VPC resources (the ones that use Create instead of CreateContext, etc.) by wrapping the provider and catching errors coming from the resources. This will need to remain a draft until the Go SDK Core PR and Go SDK Generator PR are merged and released.

Edit: the core and generator PRs are merged and this first step is ready to go.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@dpopp07 dpopp07 marked this pull request as draft March 4, 2024 21:34
@dpopp07 dpopp07 force-pushed the dp/error-structures branch 4 times, most recently from 82a2207 to bd8cf50 Compare March 15, 2024 21:53
This adds baseline support for a new error structure, created specifically
for Terraform code.

Signed-off-by: Dustin Popp <[email protected]>
@dpopp07 dpopp07 force-pushed the dp/error-structures branch from bd8cf50 to 64d0a79 Compare March 15, 2024 21:57
@dpopp07 dpopp07 marked this pull request as ready for review March 15, 2024 21:57
@hkantare hkantare merged commit d1030f6 into IBM-Cloud:master Mar 18, 2024
1 check passed
@dpopp07 dpopp07 deleted the dp/error-structures branch April 30, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants