Subnet nwacl changes #1941
Subnet nwacl changes #1941
Conversation
| }, | ||
|
|
||
| isNetworkACLVPC: { | ||
| Type: schema.TypeString, |
There was a problem hiding this comment.
This should be only computed field
There was a problem hiding this comment.
Corrected this change.
|
|
||
| isNetworkACLRules: { | ||
| Type: schema.TypeList, | ||
| Optional: true, |
There was a problem hiding this comment.
This also should be computed only
There was a problem hiding this comment.
Corrected this change.
| }, | ||
|
|
||
| isNetworkACLRuleTCP: { | ||
| Type: schema.TypeList, |
There was a problem hiding this comment.
Corrected this change.
| }, | ||
| }, | ||
|
|
||
| isNetworkACLRuleUDP: { |
There was a problem hiding this comment.
Corrected this change.
| }, | ||
|
|
||
| isNetworkACLName: { | ||
| Type: schema.TypeString, |
There was a problem hiding this comment.
Corrected this change.
|
|
||
| func resourceIBMISSubnetNetworkACLAttachmentUpdate(d *schema.ResourceData, meta interface{}) error { | ||
| hasChanged := false | ||
| if d.HasChange(isSubnetID) || d.HasChange(isNetworkACLID) { |
There was a problem hiding this comment.
subnet_id cann't be updated it forces anew resource
There was a problem hiding this comment.
Corrected this change.
|
|
||
| isNetworkACLName: { | ||
| Type: schema.TypeString, | ||
| Optional: true, |
There was a problem hiding this comment.
This should be only computed field
There was a problem hiding this comment.
Corrected this change.
|
|
||
| isNetworkACLResourceGroup: { | ||
| Type: schema.TypeString, | ||
| Optional: true, |
There was a problem hiding this comment.
This should be only computed field
There was a problem hiding this comment.
Corrected this change.
MalarvizhiK
force-pushed
the
subnet-nwacl-changes
branch
from
494793f to
c3d6f91
Compare
|
|
||
| func resourceIBMISSubnetNetworkACLAttachmentUpdate(d *schema.ResourceData, meta interface{}) error { | ||
| hasChanged := false | ||
| if d.HasChange(isNetworkACLID) { |
There was a problem hiding this comment.
No need of hasChanged variables since we have only one argument
d.HasChange(isNetworkACLID){
subnet := d.Get(isSubnetID).(string)
networkACL := d.Get(isNetworkACLID).(string)
// Construct an instance of the NetworkACLIdentityByID model
networkACLIdentityModel := new(vpcv1.NetworkACLIdentityByID)
networkACLIdentityModel.ID = &networkACL
// Construct an instance of the ReplaceSubnetNetworkACLOptions model
replaceSubnetNetworkACLOptionsModel := new(vpcv1.ReplaceSubnetNetworkACLOptions)
replaceSubnetNetworkACLOptionsModel.ID = &subnet
replaceSubnetNetworkACLOptionsModel.NetworkACLIdentity = networkACLIdentityModel
resultACL, response, err := sess.ReplaceSubnetNetworkACL(replaceSubnetNetworkACLOptionsModel)
if err != nil {
log.Printf("[DEBUG] Error while attaching a network ACL to a subnet %s\n%s", err, response)
return fmt.Errorf("Error while attaching a network ACL to a subnet %s\n%s", err, response)
}
log.Printf("[INFO] Updated subnet %s with Network ACL : %s", subnet, *resultACL.ID)
}
return resourceIBMISSubnetNetworkACLAttachmentRead(d, meta)
}
There was a problem hiding this comment.
Corrected this change.
MalarvizhiK
force-pushed
the
subnet-nwacl-changes
branch
from
2dc66ee to
36eb635
Compare
Resource ibm subnet network acl attachment