Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Cannot filter nodes from an IBM Blockchain Platform instance #2336

Closed
sstone1 opened this issue May 21, 2020 · 0 comments
Closed

Cannot filter nodes from an IBM Blockchain Platform instance #2336

sstone1 opened this issue May 21, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@sstone1
Copy link
Contributor

sstone1 commented May 21, 2020

Eclipse Theia doesn't support canPickMany: true, despite it being open for well over a year: eclipse-theia/theia#5673

We will have to work around this by just selecting all nodes instead of giving the user a choice, or by implementing it without canPickMany: true (select one, select one, select one, select finished).

@sstone1 sstone1 added bug Something isn't working che labels May 21, 2020
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue May 26, 2020
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue May 26, 2020
mergify bot pushed a commit that referenced this issue May 26, 2020
* Fix home directory references and store serialization (contributes to #2344)

Signed-off-by: Simon Stone <[email protected]>

* On Eclipse Che, use projects directory instead of home directory (resolves #2344)

Signed-off-by: Simon Stone <[email protected]>

* Stop duplicating Eclipse Che checks everywhere (contributes to #2336)

Signed-off-by: Simon Stone <[email protected]>

* Automatically select all nodes when on Eclipse Che (resolves #2336)

Signed-off-by: Simon Stone <[email protected]>
(cherry picked from commit 72067ce)

# Conflicts:
#	packages/blockchain-extension/extension/util/ExtensionUtil.ts
#	packages/blockchain-extension/test/commands/UserInputUtil.test.ts
#	packages/blockchain-extension/test/util/ExtensionUtil.test.ts
#	packages/blockchain-extension/test/util/SecureStoreFactory.test.ts
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue May 26, 2020
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue May 26, 2020
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue May 26, 2020
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue May 26, 2020
cazfletch added a commit that referenced this issue May 26, 2020
* Automatically create Fablet environment when available (resolves #2328)

Signed-off-by: Simon Stone <[email protected]>

* Fix home directory references and store serialization (contributes to #2344)

Signed-off-by: Simon Stone <[email protected]>

* On Eclipse Che, use projects directory instead of home directory (resolves #2344)

Signed-off-by: Simon Stone <[email protected]>

* Stop duplicating Eclipse Che checks everywhere (contributes to #2336)

Signed-off-by: Simon Stone <[email protected]>

* Automatically select all nodes when on Eclipse Che (resolves #2336)

Signed-off-by: Simon Stone <[email protected]>

* Determine node label before node creation (resolves #2337)

Signed-off-by: Simon Stone <[email protected]>

* Fix compile errors

Signed-off-by: Simon Stone <[email protected]>

Co-authored-by: Caroline Fletcher <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant