Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return error info if Datastore services down #560

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix: return error info if Datastore services down #560

merged 1 commit into from
Sep 12, 2024

Conversation

simon-20
Copy link
Contributor

No description provided.

@simon-20
Copy link
Contributor Author

This includes a bit of linting to code unrelated to the changes I've made--I guess the linter didn't run properly last time.

tillywoodfield
tillywoodfield reviewed Sep 12, 2024
View reviewed changes
Copy link

@tillywoodfield tillywoodfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add an integration test for the fix?

@simon-20 simon-20 merged commit f42a6e0 into develop Sep 12, 2024
3 checks passed
@simon-20 simon-20 deleted the more_err_info branch September 12, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillywoodfield tillywoodfield tillywoodfield left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon-20 @tillywoodfield