Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from linting PR #928

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Fixes from linting PR #928

merged 2 commits into from
Dec 11, 2024

Conversation

tillywoodfield
Copy link
Contributor

@tillywoodfield tillywoodfield commented Dec 10, 2024

Two fixes from previous linting PR:

  • For i18n messages containing html, the v-html binding must be used. Eslint throws a warning here, but the docs say it is okay to ignore if the html is sanitised. In this case it is static so should be fine.
  • A recent dependabot PR to develop upgraded the vue-i18n package from major version 9 to 10, so the format for interpolating variables into messages has changed from %{...} to {...}

This fix is required due to dependabot automatically merging an upgrade of vue-i18n from 9.x.x to 10.x.x
@tillywoodfield tillywoodfield changed the title Fixes Fixes from linting PR Dec 10, 2024
@tillywoodfield tillywoodfield merged commit fb5acf5 into develop Dec 11, 2024
2 checks passed
@tillywoodfield tillywoodfield deleted the fixes branch December 11, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants