Allow multiple default aid type #498
Conversation
| .. literalinclude:: ../../activity-standard-example-annotated.xml | ||
| :language: xml | ||
| :start-after: <!--default-aid-type starts--> | ||
| :end-before: <!--default-aid-type ends--> | ||
|
|
||
| The vocabulary is used to declare which AidType list is in use. If this is omitted, then IATI assumes an AidType of 1 (OECD DAC). |
There was a problem hiding this comment.
If this is omitted, then IATI assumes an AidType of 1
This is about Aid Type Vocabulary, not Aid Type. If omitted, an Aid Type Vocabulary of 1 is assumed.
There was a problem hiding this comment.
Thanks for spotting this @andylolz
|
@samuele-mattiuzzo I have made the change. Could you please review and merge? |
Keeping this consistent with aid-type by specifying that code 1 is OECD DAC
|
@PetyaKangalova will do! |
| .. literalinclude:: ../../activity-standard-example-annotated.xml | ||
| :language: xml | ||
| :start-after: <!--default-aid-type starts--> | ||
| :end-before: <!--default-aid-type ends--> | ||
|
|
||
| The vocabulary is used to declare which AidType list is in use. If omitted, an AidType Vocabulary of 1 (OECD DAC) is assumed. |
There was a problem hiding this comment.
“AidTypeVocabulary” and “Aid Type Vocabulary” are used interchangeably in the docs (ref). Not really keen on this new version (“AidType Vocabulary”).
| <default-aid-type code="A01" vocabulary="1" /> | ||
|
|
||
|
|
||
| The default-aid-type element can be repeated in any iati-activity. |
There was a problem hiding this comment.
I think this should be clarified to something like:
The
default-aid-typeelement must not be used more than once for each vocabulary.
From the discussion on Discuss:
Also, I think this should be done in a new Rule, because at present the (automatically generated) rules on that page are the most confusing (and inaccurate) thing:
There was a problem hiding this comment.
Hi @markbrough your suggested wording, but with a should, is already in the activity schema. We are working on trying to get this shown on the website: https://github.com/IATI/IATI-Schemas/blob/version-2.03/iati-activities-schema.xsd
There was a problem hiding this comment.
Oh excellent, thanks @amy-silcock! Yes agree that is a better approach :)
There was a problem hiding this comment.
We are working on trying to get this shown on the website
I suppose you mean this line. Quite difficult to figure out what happened with this. It was added to the wrong branch in IATI/IATI-Schemas#418, then reverted in IATI/IATI-Schemas#420… I guess it was re-added recently, and hasn’t actually been deployed. So I’d suggest deploying v2.03.
As usual, I think auto-deploying the reference site from github would be a really sensible step that could save some headaches. See: IATI/IATI-Standard-SSOT#164.
Linked to issue: IATI/IATI-Codelists#169