-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rbsys to support Ruby 3.3 #21
Conversation
Fixes #20 |
@bmulholland Maybe I've done something wrong but I'm not sure this fixes #20
Full deploy output including error
|
@karlentwistle you will still need to install libclang |
Does anyone know a good way to install |
Ah, I see, thanks very much for letting me know 🙇
I got it working with karlentwistle/tiktoken_heroku_example@583a5c7 and https://elements.heroku.com/buildpacks/heroku/heroku-buildpack-apt Can also now confirm this PR does indeed fix #20 😄 |
Howdy @IAPark, this is blocking projects from moving to Ruby 3.3. Any chance this can be merged? |
Curious. Why is |
@ScotterC Maybe because there's a prebuilt version for ruby 3.2, but not 3.3? Ref: #20 (comment) |
Yup here's where the builds are created https://github.com/IAPark/tiktoken_ruby/blob/main/.github/workflows/build.yml#L9. If I understood more clearly how that build ends up creating the precompiled version on rubygems or locally then I'd create a PR for it. I'm loathe to add another buildpack to Heroku since I'm feeling the platform lock-in lately. |
Did anyone here fork the gem for Ruby 3.3 ? |
@xfalcox only forks updated recently are similar to this PR. Updating rb_sys. Here's thoughtbot's https://github.com/thoughtbot/tiktoken_ruby |
Closed in favor of #22 (kinda by accident) |
Also, the truth is I created this gem in a weekend because I was annoyed at work and we've sense moved in a direction where it's irrelevant. It kinda just gives me a bit of stress now when I'm reminded of it. I think I should probably put a notice up asking if anyone wants to take it over |
In theory this should be out now though cross compiling seems broken and I might not be able to get back to it until next weekend at the earliest |
@IAPark thanks for the work! I'll see if I can help find a maintainer |
The tests pass and this seems to work perfectly as far as I can tell.