-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix AR6 database reading #649
Conversation
If I could get a hand adding a test that reading from the AR6 database behaves as intended that would be great |
iam-units is waiting on IAMconsortium/units#37, tests won't pass until that happens |
I think the error is due to a change in pandas (https://stackoverflow.com/questions/63553845/pandas-read-json-valueerror-protocol-not-known), although I'm a bit puzzled why there is no issue with reading from the SR1.5 database as I thought the same error would occur... You could try those casting to string type solutions first, or you could just use |
I think the change you are refering to has been addressed in #621 ; BUT: i am not sure. ie the content attribute is a bytes string, but text has already been decoded. I'll have a short look whether i'll figure out what i think is the problem instead. |
I don't encounter any error with the current |
Had a second look. I am getting the same problem, you are reporting with python 3.7. Starting from python 3.8, it works fine. I guess using the json method from requests would be getting around that as you propose here. |
It's not a big issue, I'll just a Python 3.9 environment. Thanks for taking a look! |
Please confirm that this PR has done the following:
- [ ] Name of contributors Added to AUTHORS.rstAdding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)
Please add a single line in the release notes similar to the following:
Description of PR
The downloader doesn't appear happy with the AR6 database, see below. This PR (firstly suggests a fix before hopefully) fixes that.