Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pydantic <1.11, Test compatibility among supported Python and pydantic versions. #122

Merged
merged 9 commits into from
Jun 15, 2023

Conversation

ewdurbin
Copy link
Contributor

@ewdurbin ewdurbin commented Jun 8, 2023

Closes #119

This is just a draft of setting up an initial test matrix

Code Changes

  • Loosens dependency spec for pydantic
  • Updates pytest for 3.10+ compat
  • Builds a simple noxfile.py
  • add matrixes for static checks and tests

Steps to Confirm

  • run nox locally
  • look at GitHub actions results

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

In order to be generally usable as a library, fideslang should do its best to test against varying Python versions and versions of libraries it depends on. Given that pydantic compatibility is relatively sensitive, this is the only library targeted in this effort.

@ewdurbin
Copy link
Contributor Author

ewdurbin commented Jun 8, 2023

@ThomasLaPiana, here's an initial sketch of a nox based test matrix for fideslang.

Major downside here is that the lack of nox integration means enumerating our matrix in two places (noxfile.py and the GitHub workflow). I'm going to look into if there's a well supported way of automatically discovering them.

@ewdurbin ewdurbin force-pushed the test_matrix branch 2 times, most recently from 0d53121 to 660bdba Compare June 11, 2023 14:06
@ewdurbin ewdurbin changed the title Draft: setup an initial test matrix Support Pydantic <1.11, Test compatibility among supported Python and pydantic versions. Jun 14, 2023
@ewdurbin ewdurbin marked this pull request as ready for review June 14, 2023 12:45
@ThomasLaPiana ThomasLaPiana self-assigned this Jun 15, 2023
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin to pydantic < 1.10.0
2 participants