Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cookies Schema #115

Merged
merged 12 commits into from
Jun 19, 2023
Merged

Add Cookies Schema #115

merged 12 commits into from
Jun 19, 2023
+42 −7

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Jun 6, 2023 •
edited by ThomasLaPiana
Loading

Closes #114

Code Changes

  • Add Cookies schemal and optional PrivacyDeclaration.cookies field
  • Commit some other formatting/sorting fixes

Steps to Confirm

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

We want to be able to map cookies to the data uses of a system so they can be associated with the appropriate privacy notices for user consent.

@pattisdr pattisdr mentioned this pull request Jun 15, 2023
Merged
14 tasks
@pattisdr pattisdr changed the title Add optional cookies field to PrivacyDeclaration. Add Cookies Schema Jun 15, 2023
ThomasLaPiana
ThomasLaPiana approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ThomasLaPiana
Copy link
Contributor

@pattisdr I'm assuming we'll need a new release for this?

@pattisdr
Copy link
Contributor Author

Thanks for the review @ThomasLaPiana! Yes I believe we'll need a release to this, I'm going to wait to merge this until we get the fides PR that needs this better tested and reviewed to make sure there are no further fideslang changes required.

@ThomasLaPiana
Copy link
Contributor

@pattisdr sounds good! Feel free to merge 🙂 I'll also work on a fix for the bug you found

@pattisdr
Copy link
Contributor Author

thanks very much @ThomasLaPiana!

@pattisdr pattisdr merged commit b66cd35 into main Jun 19, 2023
@pattisdr pattisdr deleted the fideslang_114_privacy_declaration_cookies branch June 19, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasLaPiana ThomasLaPiana ThomasLaPiana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Backend] Add Optional PrivacyDeclaration.cookies field
2 participants
@pattisdr @ThomasLaPiana