Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprites for shadows, running, and bashing #2063

Merged
merged 8 commits into from
Jul 23, 2023

Conversation

Rewryte
Copy link
Contributor

@Rewryte Rewryte commented Jul 14, 2023

Summary

Assigns sprites for z-level shadows and running / bashing animations

Content of the change

Z-level shadows were added in CleverRaven/Cataclysm-DDA#66730
A few tilesets already have their own shadow sprites so I reused them. Made new sprites for the rest. My sprites are made with Krita 5.1 and saved with default settings.

Running and smashing animations were added in CleverRaven/Cataclysm-DDA#65622
I reused the animation_hit sprite as bash_effective and fd_smoke as both bash_complete and run_*. If a tileset lacks these sprites then nothing will be added.

Testing

Tilesets compiled successfully. Tested shadows, running and bashing for each modified tileset.

Shadows (UltiCa)
1
Bashing (MSX+)
2
Running (BrownLikeBears)
3

Additional information

@Rewryte Rewryte marked this pull request as ready for review July 14, 2023 15:18
@Fris0uman
Copy link
Collaborator

I'm afraid using smoke for running is going to be confusing. Right now smoke is something you need to pay attention to and avoid, it's a bad idea to reuse a sprite of a danger for something cosmetic

@Rewryte
Copy link
Contributor Author

Rewryte commented Jul 17, 2023

Alright, I'll glance through the sprite sheets to see if anything else catches my eye but I'll probably just remove the run animation if I can't find anything. If you have any suggestions, feel free to share them.

We cool with fd_smoke as bash_complete?

@Fris0uman
Copy link
Collaborator

We cool with fd_smoke as bash_complete?

No, it's the same issue, using the srpite for something dangerous for something that is not

@Rewryte Rewryte marked this pull request as draft July 22, 2023 14:49
@Rewryte Rewryte marked this pull request as ready for review July 22, 2023 19:15
@Rewryte
Copy link
Contributor Author

Rewryte commented Jul 22, 2023

No, it's the same issue, using the srpite for something dangerous for something that is not

Ok. Got rid of that as well.

Also changed bash_effective to use glass crack sprites if exists.

@Fris0uman Fris0uman merged commit 4352ecd into I-am-Erk:master Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants