Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isometric tileset changes for 3d vision #2036

Merged
merged 10 commits into from
Jun 23, 2023
Merged

Conversation

Rewryte
Copy link
Contributor

@Rewryte Rewryte commented Jun 22, 2023

Summary

Tileset changes for CleverRaven/Cataclysm-DDA#66383

Content of the change

Basically the isometric counterpart of #2008.
This should only be merged if CleverRaven/Cataclysm-DDA#66383 is.

Isometric tilesets require minor changes as follows:

  • t_open_air and variants should either be unassigned or semi-transparent. I opted to unassign them and let the fallback fog do the job. Feel free to replace it if there is something better.
  • tr_ledge needs to be assigned a blank sprite to prevent a fallback sprite from being drawn.

Affected tilesets are SmashButton_iso and Ultica_iso.
My sprites are made in Krita 5.1 and saved using default settings.

Testing

Compose script ran successfully and modified tiles interact properly with the 3D vision PR. Did not notice any unintended changes in comparison to the current master.

Additional information

@Rewryte Rewryte marked this pull request as ready for review June 23, 2023 15:02
@Fris0uman
Copy link
Collaborator

hitbutton is missing a t_open_air sprite here, no?

@Rewryte
Copy link
Contributor Author

Rewryte commented Jun 23, 2023

hitbutton is missing a t_open_air sprite here, no?

Well, you're not wrong. The 3D vision PR includes changes to the fallback system when sprites are not found. A missing t_open_air will cause fog to be drawn in its place.

@Fris0uman
Copy link
Collaborator

You're removng the json that assigns 687_t_open_air_0 to t_open_air, you could instead edit 687_t_open_air_0 to be the fog and rename it t_open_air

@Rewryte
Copy link
Contributor Author

Rewryte commented Jun 23, 2023

Yeah, I guess I could. It wouldn't be exactly the same, but after trying it out it did not turn out as bad as I thought it would. Main difference is that the fog is drawn a bit higher than the code would have done.

Chiquita Waters _2023-06-24T00-27-02

@Fris0uman Fris0uman merged commit 6cf0a5a into I-am-Erk:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants