Dashboard e2 e #1507
Open
Dashboard e2 e #1507
+253
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozzy11
reviewed
Feb 10, 2025
frontend/cypress/e2e/dashboard.cy.js
Outdated
| }); | ||
|
|
||
| it("User adds a new Pathology order", function () { | ||
| homePage.goToOrderPage(); | ||
| dashboard.addOrder("Histopathology"); | ||
| dashboard.searchPatientByFName(); |
There was a problem hiding this comment.
Thanks @Bahati308 .
These steps looks duplicated. can you just define a generic function to add an oder with a program ??
mozzy11
reviewed
Feb 10, 2025
| @@ -1,81 +1,131 @@ | |||
| class DashBoardPage { | |||
| addOrder(Program) { | |||
| cy.fixture("Order").then((order) => { | |||
There was a problem hiding this comment.
I think this was a good generic function to add an order with a program.
Can you just improve this function selectors and re-use it across the three programs??
mozzy11
reviewed
Feb 10, 2025
|
|
||
| // Helper function to add a new order | ||
| const addNewOrder = (dashboardType, testType, sampleType, panelType) => { | ||
| homePage.goToOrderPage(); |
There was a problem hiding this comment.
does this function really add a coresponding program ??
i dont see where dashboardType is used with in the function
There was a problem hiding this comment.
ALright , i think i had confused dashboardtype with the program
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the dashboard E2E
Summary
Hardened selectors and improved functionality
Screenshots
[Add relevant screenshots here if applicable]
Related Issue
fixes #1505
https://uwdigi.atlassian.net/browse/OGC-28
Other
https://uwdigi.atlassian.net/issues/OGC-31?jql=issueKey%20in%20%28OGC-28%2COGC-30%2COGC-29%2COGC-31%2COGC-32%29