Set ssl.OP_LEGACY_SERVER_CONNECT in order to be able to connect to unsafe SSL servers that OpenSSL 3.0.0 prohibits by default now. #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in Python yet, but in OpenSSL its value is 0x4 in the bitfield.
|
Thanks for quick fix |
|
Looks like for some reason the semantic pull CI didn't run on this. Since it wasn't semantic the release pipeline didn't run. I will push it manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SSL context to enable ssl.OP_LEGACY_SERVER_CONNECT, which isn't in Python yet (see python/cpython#89051, it'll be in 3.12), but in OpenSSL its value is 0x4 in the bitfield.
Fixes Hyundai-Kia-Connect/kia_uvo#678 and Hyundai-Kia-Connect/kia_uvo#679.
Once this is merged, you'll need to do a version bump of this and then bump the version of the required API in Hyundai-Kia-Connect/kia_uvo, obviously.