Sampling fix #624
Merged
Sampling fix #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwlchan
reviewed
May 14, 2017
tests/cover/test_sampled_from.py
Outdated
|
|
||
| @given(sampled_from(an_enum)) | ||
| def test_can_sample_enums(member): | ||
| assert isinstance(member, an_enum) |
There was a problem hiding this comment.
Worth running in strict mode to see that we don't raise a DeprecationWarning?
There was a problem hiding this comment.
Done - if there's nothing else, I'd appreciate an approval so I can juggle some merges before going to bed.
DRMacIver
approved these changes
May 15, 2017
|
Will merge in a few hours, after the pending things are done. |
|
...the build is going to fail, because it has yesterday's date in the changelog. @DRMacIver, is this the time for your admin powers to shine? |
Not sure there's much I can do about that, but if you give me a pull request to update the date, I'll happily fast track it through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny compatibility fix for
sampled_from, allowing Enums without a deprecation warning. Closes #595.Uses the current year (in UTC) for the sphinx copyright notice.