Add special case shrink pass for sums of integers #2496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't currently reduce tests that look like the following well:
In that we might end up with basically any pair
(m, n)
withm + n == 1001
, when ideally we'd always end up withm = 1, n = 1000
.It'd be nice to normalise such a simple test. This PR adds a special case shrinking pass for tests that have sum lower bounds like this.
Full disclosure: This is me cheating at a benchmark. https://github.com/jlink/shrinking-challenge/blob/main/challenges/bound5.md