Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shrink pass for reordering examples #1404

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

DRMacIver
Copy link
Member

@DRMacIver DRMacIver commented Jul 18, 2018

This is the second chunk of work I alluded to in #1403. It adds the ability to reorder whole examples.

Fixes #1094 (which I had intended to leave for someone else to do, but oh well)

@DRMacIver DRMacIver force-pushed the DRMacIver/example-reordering branch from 1e5f408 to 0ce8a2a Compare July 19, 2018 12:47
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the changelog is fixed up, LGTM 🚀

def test_does_not_exceed_100(m, n):
assert m + n < 100
@given(st.text(), st.text())
def test_does_not_exceed_100(x, y):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be e.g. test_example_text(x, y)?

@DRMacIver DRMacIver force-pushed the DRMacIver/example-reordering branch from 0ce8a2a to 5aedba8 Compare July 20, 2018 11:08
@Zac-HD
Copy link
Member

Zac-HD commented Jul 20, 2018

Looks like you managed to rebase onto a different pre-existing RELEASE.rst 🤣 (otherwise still LGTM)

@DRMacIver
Copy link
Member Author

Looks like you managed to rebase onto a different pre-existing RELEASE.rst 🤣 (otherwise still LGTM)

🤦‍♂️

@DRMacIver DRMacIver force-pushed the DRMacIver/example-reordering branch from 5aedba8 to 9e6a523 Compare July 20, 2018 12:09
@DRMacIver DRMacIver merged commit a8aaf2c into master Jul 20, 2018
@DRMacIver DRMacIver deleted the DRMacIver/example-reordering branch July 20, 2018 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants