Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow skipping NaT in extra.numpy.from_dtype with datetime64_dtypes and timedelta64_dtypes #3943

Closed
dcherian opened this issue Mar 31, 2024 · 0 comments · Fixed by #3946
Closed
Labels
enhancement it's not broken, but we want it to be better

Comments

@dcherian
Copy link

The allow_nan kwarg does not let me skip NaT. It'd be nice to add a specific allow_nat kwarg.

@Zac-HD Zac-HD added the enhancement it's not broken, but we want it to be better label Mar 31, 2024
dcherian added a commit to dcherian/xarray that referenced this issue Apr 1, 2024
dcherian added a commit to pydata/xarray that referenced this issue Apr 3, 2024
* Stateful tests with Dataset

* Disable check_default_indexes when needed

* Add Zarr roundtrip

* Randomize dimension choice

* Fix a bug

* Add reset_index

* Add stack, unstack

* [revert] Disable Zarr till we control attrs strategy

* Try making unique names

* Share names strategy to ensure uniques?

* cleanup

* Try sharing strategies better

* Fix endianness

* Better swap_dims

* More improvements

* WIP

* Drop duplicates before unstacking

* Add reset_index

* Better duplicate assumption

* Move

* Fix reset_index

* Skip if hypothesis not installed

* Better precondition around reset_index

* Note

* Try a bundle

* Use unique_subset_of

* Use Bundles more

* Add index_variables strategy

* Small improvement

* fix

* Use st.shared

* Revert "Use st.shared"

This reverts commit 50f6030.

* fix unstacking

* cleanup

* WIP

* Remove bundles

* Fixes

* Add hypothesis cache to CI

* Prevent index variables with NaNs, infs

* [revert]

* Always save hypothesis cache

* Expand dtypes

* Add invariant check for #8646

* Add drop_dims

* Add create_index to stack

* Generalize a bit

* limit number of indexes  to stack

* Fix endianness?

* uniquify drop_dims

* Avoid NaTs in index vars

HypothesisWorks/hypothesis#3943

* Guard swap_dims

* Revert "Add invariant check for #8646"

This reverts commit 4a958dc.

* Add drop_indexes

* Add assign_coords

* Fix max_period for pandas timedelta

* Add xfailed test

* Add notes

* Skip timedelta indexes

* to_zarr

* small tweaks

* Remove NaT assume

* Revert "[revert]"

This reverts commit 6a38e27.

* Add hypothesis workflow

* Swtich out

* fix

* Use st.builds

* cleanup

* Add initialize

* review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement it's not broken, but we want it to be better
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants