Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release2.2 add gm bccsp show demo #12

Open
wants to merge 1 commit into
base: bccsp-gm
Choose a base branch
from

Conversation

guijunchen
Copy link
Member

Signed-off-by: Guijun Chen [email protected]

Type of change

  • Bug fix
  • New feature
  • Improvement (improvement to code, performance, etc)
  • Test update
  • Documentation update

Description

Additional details

Related issues

@davidkhala
Copy link
Member

@SamYuan1990 @davidkhala

@SamYuan1990
Copy link
Member

SamYuan1990 commented Sep 21, 2021

add comments in #13, with to do

in general, for short, we may?

  • make a new package named gm for all gm impls.
  • make gm as same level as sw.
  • adding test for gm package.

further considering,
for coding block as

switch key.type...
// should we instead this by a reg, which reg the types in to a container (map/array etc)
// and for _,v := range the container {
//. if key == v
//}

but limited with golang build.

for const, we can move into a new package?
for others as key import, as we put in a new package, we can impl in the package instead of modify existing?

@SamYuan1990
Copy link
Member

we will offline discuss it on next gm group regular meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants