Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COMP-LABELS] Cleanup and fix composable-labels model changeset #2155

Merged

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Nov 4, 2024

Changes proposed

  • Remove unnecessary public schema
  • Remove ALTER OWNER instructions
  • Add GRANT ALL to the created sequences
  • Gave a bit more meaningful names to foreign keys

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@lampajr lampajr requested a review from willr3 November 4, 2024 16:59
@lampajr lampajr changed the title Cleanup and fix composable-labels model changeset [COMP-LABELS] Cleanup and fix composable-labels model changeset Nov 4, 2024
@lampajr
Copy link
Member Author

lampajr commented Nov 4, 2024

This is still not enough.. there are still some missing permission somewhere

@lampajr lampajr force-pushed the composable-labels_fic_changelog branch from 6924890 to b3468a6 Compare November 4, 2024 17:29
@lampajr lampajr force-pushed the composable-labels_fic_changelog branch from b3468a6 to 1ec0654 Compare November 4, 2024 20:08
@lampajr
Copy link
Member Author

lampajr commented Nov 4, 2024

This is still not enough.. there are still some missing permission somewhere

Ok now the permissions should be properly set.

Tests are working and the changset execution works with a prod backup as well.

@willr3 willr3 merged commit 7693cc6 into Hyperfoil:composable-labels Nov 4, 2024
2 checks passed
@lampajr lampajr deleted the composable-labels_fic_changelog branch December 11, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants