[0.12.x] MPL-68: make run_schemas updates asynchronous #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lampajr please could you take a look at the test failures for this backport? |
lampajr
requested changes
Apr 15, 2024
horreum-backend/src/main/java/io/hyperfoil/tools/horreum/svc/ServiceMediator.java
Outdated
Show resolved
Hide resolved
lampajr
force-pushed
the
bp-0.12.x-e30e650
branch
from
e9266b9 to
5f0a4d8
Compare
|
@lampajr thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport: #1581
Fixes Issue
Fixes #1579
Changes proposed
Changes:
schema-sync-{in, out}and related eventCreateOrUpdateEvent(TBH I think this could be simplified further as we just need theschemaIdvalue, thus we can remove the event and keep an id only)newOrUpdatedSchemafromServiceMediatortoSchemaServiceImplfor coherence (especially as we need the TxManager)runService.onNewOrUpdatedSchema(event.id);asynchronousCheck List (Check all the applicable boxes)